Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit fdebc2f

Browse files
authoredNov 9, 2017
Merge pull request #197 from ckeditor/t/193
Fix: Removed a period at the end of an error message because some browsers included the period in links to errors. Closes #193.
2 parents ab11565 + c0dc863 commit fdebc2f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed
 

‎src/ckeditorerror.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,5 +82,5 @@ export function attachLinkToDocumentation( message ) {
8282
return message;
8383
}
8484

85-
return message + ` Read more: ${ DOCUMENTATION_URL }#${ matchedErrorName[ 1 ] }.\n`;
85+
return message + ` Read more: ${ DOCUMENTATION_URL }#${ matchedErrorName[ 1 ] }\n`;
8686
}

‎tests/ckeditorerror.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ describe( 'CKEditorError', () => {
5656
const error = new CKEditorError( 'model-schema-no-item: Specified item cannot be found.' );
5757

5858
const errorMessage = 'model-schema-no-item: Specified item cannot be found. ' +
59-
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n`;
59+
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n`;
6060

6161
expect( error ).to.have.property( 'message', errorMessage );
6262
} );
@@ -65,7 +65,7 @@ describe( 'CKEditorError', () => {
6565
const error = new CKEditorError( 'model-schema-no-item: Specified item cannot be found.', { foo: 1, bar: 2 } );
6666

6767
const errorMessage = 'model-schema-no-item: Specified item cannot be found. ' +
68-
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n ` +
68+
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n ` +
6969
'{"foo":1,"bar":2}';
7070

7171
expect( error ).to.have.property( 'message', errorMessage );

‎tests/log.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe( 'log', () => {
3838
log.warn( 'model-schema-no-item: Specified item cannot be found.' );
3939

4040
const logMessage = 'model-schema-no-item: Specified item cannot be found. ' +
41-
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n`;
41+
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n`;
4242

4343
sinon.assert.calledOnce( spy );
4444
sinon.assert.calledWith( spy, logMessage );
@@ -66,7 +66,7 @@ describe( 'log', () => {
6666
log.error( 'model-schema-no-item: Specified item cannot be found.' );
6767

6868
const logMessage = 'model-schema-no-item: Specified item cannot be found. ' +
69-
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n`;
69+
`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n`;
7070

7171
sinon.assert.calledOnce( spy );
7272
sinon.assert.calledWith( spy, logMessage );

0 commit comments

Comments
 (0)
This repository has been archived.