Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: abort code generation on finding a lookup of size zero #162

Merged
merged 2 commits into from
Nov 19, 2021
Merged

fix: abort code generation on finding a lookup of size zero #162

merged 2 commits into from
Nov 19, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Nov 4, 2021 •
edited by chrispcampbell
Loading

Fixes #161

@ToddFincannon ToddFincannon changed the title throw an error when the lookup size < 1 when generating __new_lookup fix: abort code generation on finding a lookup of size zero Nov 4, 2021
@chrispcampbell chrispcampbell merged commit 44c1202 into develop Nov 19, 2021
@chrispcampbell chrispcampbell deleted the todd/161-zero-size-lookup branch November 19, 2021 05:59
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lookups of size zero result in invalid memory access
2 participants
@ToddFincannon @chrispcampbell