Skip to content

Commit f34d200

Browse files
authored
Fixed typos and punctuation (#1476)
Signed-off-by: Jana Rangasamy <[email protected]>
1 parent 291afe8 commit f34d200

File tree

5 files changed

+23
-23
lines changed

5 files changed

+23
-23
lines changed

CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ The CLOMonitor project accepts contributions via [GitHub pull requests](https://
44

55
## Issues and discussions
66

7-
Feature requests, bug reports, and support requests all occur through GitHub issues and discussions. If you would like to file an issue, view existing issues, or comment on an issue please engage with issues at <https://github.com/cncf/clomonitor/issues>. You can create new discussions, view existing ones and comment on them at <https://github.com/cncf/clomonitor/discussions>.
7+
Feature requests, bug reports, and support requests all occur through GitHub issues and discussions. If you would like to file an issue, view existing issues, or comment on an issue, please engage with issues at <https://github.com/cncf/clomonitor/issues>. You can create new discussions, view existing ones and comment on them at <https://github.com/cncf/clomonitor/discussions>.
88

99
## Pull Requests
1010

11-
All changes to the source code and documentation are made through [GitHub pull requests](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests). If you would like to make a change to the source, documentation, or other component in the repository please open a pull request with the change.
11+
All changes to the source code and documentation are made through [GitHub pull requests](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests). If you would like to make a change to the source, documentation, or other component in the repository, please open a pull request with the change.
1212

13-
If you are unsure if the change will be welcome you may want to file an issue first. The issue can detail the change and you can get feedback from the maintainers prior to starting to make the change.
13+
If you are unsure if the change will be welcome, you may want to file an issue first. The issue can detail the change and you can get feedback from the maintainers prior to starting to make the change.
1414

1515
You can find the existing pull requests at <https://github.com/cncf/clomonitor/pulls>.
1616

@@ -88,6 +88,6 @@ Date: Thu Feb 2 11:41:15 2018 -0800
8888
Signed-off-by: Joe Smith <[email protected]>
8989
```
9090

91-
Notice how the `Author` and `Signed-off-by` lines match. If they do not match the PR will be rejected by the automated DCO check.
91+
Notice how the `Author` and `Signed-off-by` lines match. If they do not match, the PR will be rejected by the automated DCO check.
9292

93-
If more than one person contributed to a commit than there can be more than one `Signed-off-by` line where each line is a signoff from a different person who contributed to the commit.
93+
If more than one person contributed to a commit, then there can be more than one `Signed-off-by` line where each line is a signoff from a different person who contributed to the commit.

docs/architecture.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ This layer represents a set of **Rust APIs** that provide some core functionalit
8181

8282
It's composed of two modules:
8383

84-
- **linter:** this module implements the core linting functionality of CLOMonitor. All checks currently run by CLOMonitor are handled by this module, and both the `CLI tool` and the `tracker` rely on it. The linter is able to run multiple `check sets` on each repository. Each `check set` defines a number of checks that will be run on the repository. For more details about what checks are run on each `check set` please see the [checks documentation](https://github.com/cncf/clomonitor/blob/main/docs/checks.md).
84+
- **linter:** this module implements the core linting functionality of CLOMonitor. All checks currently run by CLOMonitor are handled by this module, and both the `CLI tool` and the `tracker` rely on it. The linter is able to run multiple `check sets` on each repository. Each `check set` defines a number of checks that will be run on the repository. For more details about what checks are run on each `check set`, please see the [checks documentation](https://github.com/cncf/clomonitor/blob/main/docs/checks.md).
8585

8686
- **score:** this module is in charge of scoring reports produced by the linter. The linter will produce different reports for each of the kinds supported, and each of the reports will be scored differently as well. In addition to the reports' scoring functionality, this module provides some score related features as well, like rating a given score or merging multiple scores.
8787

docs/checks.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
**CLOMonitor** runs sets of checks periodically on all the repositories registered in the database. These checks are run *every hour*, provided the repository has changed since the last time it was checked. In the case of repositories that don't change often, we make sure that they are checked at least *once a day* anyway. This way we keep reports up to date with the latest checks additions and improvements.
44

5-
Checks are organized in `check sets`. Each `check set` defines a number of checks that will be run on the repository and one or more `check sets` can be applied to a single repository. At the moment the following sets are supported: `code`, `code-lite`, `community` and `docs`. The set of checks run for each one are as follows:
5+
Checks are organized in `check sets`. Each `check set` defines a number of checks that will be run on the repository and one or more `check sets` can be applied to a single repository. At the moment, the following sets are supported: `code`, `code-lite`, `community` and `docs`. The set of checks run for each one are as follows:
66

77
- **code** (recommended for projects' primary code repository)
88

@@ -65,7 +65,7 @@ Checks are organized in `check sets`. Each `check set` defines a number of check
6565

6666
Many checks rely on checking that certain files exists on a given path. Even though most of these checks support a number of variants, sometimes this won't work for some projects that may be using a different repository layout. In those cases, the recommended approach is to add a section to the `README` file of the repository pointing users to the document location. This will help users discovering this information and will make CLOMonitor happy :) At the moment we support detecting headers as well as links in `README` files that follow some patterns. Please see the reference below for more information on each case. Some projects have already proceeded this way successfully: [Kubernetes clomonitor PR](https://github.com/kubernetes/kubernetes/pull/108110), [KEDA clomonitor PR](https://github.com/kedacore/keda/pull/2704) and [Cilium clomonitor PR](https://github.com/cilium/cilium/pull/19037).
6767

68-
For more details about how each of the checks are performed, please see the reference below. Note that **CLOMonitor** does not follow symlinks when reading files content. If you find that any of the checks isn't working as expected or you have ideas about how to improve them please [file an issue](https://github.com/cncf/clomonitor/issues) or [open a discussion](https://github.com/cncf/clomonitor/discussions) in GitHub.
68+
For more details about how each of the checks are performed, please see the reference below. Note that **CLOMonitor** does not follow symlinks when reading files content. If you find that any of the checks isn't working as expected or you have ideas about how to improve them, please [file an issue](https://github.com/cncf/clomonitor/issues) or [open a discussion](https://github.com/cncf/clomonitor/discussions) in GitHub.
6969

7070
## Exemptions
7171

@@ -467,7 +467,7 @@ This check passes if:
467467

468468
**ID**: `openssf_scorecard_badge`
469469

470-
Scorecard assesses open source projects for security risks through a series of automated checks. For more information about the Scorecard badge please see <https://github.com/marketplace/actions/ossf-scorecard-action#scorecard-badge>.
470+
Scorecard assesses open source projects for security risks through a series of automated checks. For more information about the Scorecard badge, please see <https://github.com/marketplace/actions/ossf-scorecard-action#scorecard-badge>.
471471

472472
This check passes if:
473473

@@ -512,23 +512,23 @@ This check passes if:
512512

513513
This check determines whether the project has generated executable (binary) artifacts in the source repository.
514514

515-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#binary-artifacts) in the ossf/scorecard repository.*
515+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#binary-artifacts) in the ossf/scorecard repository.*
516516

517517
### Code review (from OpenSSF Scorecard)
518518

519519
**ID**: `code_review`
520520

521521
This check determines whether the project requires code review before pull requests (merge requests) are merged.
522522

523-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#code-review) in the ossf/scorecard repository.*
523+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#code-review) in the ossf/scorecard repository.*
524524

525525
### Dangerous workflow (from OpenSSF Scorecard)
526526

527527
**ID**: `dangerous_workflow`
528528

529529
This check determines whether the project's GitHub Action workflows has dangerous code patterns.
530530

531-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#dangerous-workflow) in the ossf/scorecard repository.*
531+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#dangerous-workflow) in the ossf/scorecard repository.*
532532

533533
### Dependencies policy
534534

@@ -546,15 +546,15 @@ This check passes if:
546546

547547
This check tries to determine if the project uses a dependency update tool, specifically [dependabot](https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates) or [renovatebot](https://docs.renovatebot.com/configuration-options/).
548548

549-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool) in the ossf/scorecard repository.*
549+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool) in the ossf/scorecard repository.*
550550

551551
### Maintained (from OpenSSF Scorecard)
552552

553553
**ID**: `maintained`
554554

555555
This check determines whether the project is actively maintained.
556556

557-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained) in the ossf/scorecard repository.*
557+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained) in the ossf/scorecard repository.*
558558

559559
### Security insights
560560

@@ -600,7 +600,7 @@ CASE SENSITIVE: false
600600

601601
This check tries to determine if the project cryptographically signs release artifacts.
602602

603-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#signed-releases) in the ossf/scorecard repository.*
603+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#signed-releases) in the ossf/scorecard repository.*
604604

605605
### Software bill of materials (SBOM)
606606

@@ -631,7 +631,7 @@ This check passes if:
631631

632632
This check determines whether the project's automated workflows tokens are set to read-only by default.
633633

634-
*This is an OpenSSF Scorecard check. For more details please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions) in the ossf/scorecard repository.*
634+
*This is an OpenSSF Scorecard check. For more details, please see the [check documentation](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions) in the ossf/scorecard repository.*
635635

636636
## Legal
637637

docs/dev.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ clomonitor_db_init
1919
clomonitor_db_server
2020
```
2121

22-
Once the database server is up an running, we can create the `clomonitor` database and we'll be ready to go:
22+
Once the database server is up and running, we can create the `clomonitor` database and we'll be ready to go:
2323

2424
```sh
2525
clomonitor_db_create
@@ -47,7 +47,7 @@ clomonitor_db_migrate
4747

4848
### Database tests
4949

50-
If you plan to do some work on the database layer, some extra setup is needed to be able to run the database tests. [Schema and database functions are tested](https://github.com/cncf/clomonitor/tree/main/database/tests) using the unit testing framework [pgTap](https://pgtap.org), so you need to [install](https://pgtap.org/documentation.html#installation) the pgTap PostgreSQL extension on your machine. To run the tests you will also need to install a perl tool called [pg_prove](https://pgtap.org/pg_prove.html) from CPAN (`cpan TAP::Parser::SourceHandler::pgTAP`).
50+
If you plan to do some work on the database layer, some extra setup is needed to be able to run the database tests. [Schema and database functions are tested](https://github.com/cncf/clomonitor/tree/main/database/tests) using the unit testing framework [pgTap](https://pgtap.org), so you need to [install](https://pgtap.org/documentation.html#installation) the pgTap PostgreSQL extension on your machine. To run the tests, you will also need to install a perl tool called [pg_prove](https://pgtap.org/pg_prove.html) from CPAN (`cpan TAP::Parser::SourceHandler::pgTAP`).
5151

5252
Similarly to what we did during our initial database setup, we'll create a configuration file for Tern for the tests database in the same folder (`~/.config/clomonitor`), called `tern-tests.conf` with the following content (please adjust if needed):
5353

@@ -81,7 +81,7 @@ insert into foundation values ('cncf', 'CNCF', 'https://raw.githubusercontent.co
8181

8282
The `registrar` component will process the foundations' data files and register the projects available.
8383

84-
At this point our database is ready to launch our local instance of CLOMonitor and start doing some work on it.
84+
At this point, our database is ready to launch our local instance of CLOMonitor and start doing some work on it.
8585

8686
## Backend
8787

@@ -122,7 +122,7 @@ Now you can run the `apiserver`:
122122
clomonitor_apiserver
123123
```
124124

125-
The `apiserver` process launches an http server that serves the web application and the API that powers it. Once it is up and running, you can point your browser to [http://localhost:8000](http://localhost:8000) and you should see the CLOMonitor web application. Initially there won't be any projects listed on it, but we'll take care of that in the next section.
125+
The `apiserver` process launches an http server that serves the web application and the API that powers it. Once it is up and running, you can point your browser to [http://localhost:8000](http://localhost:8000) and you should see the CLOMonitor web application. Initially, there won't be any projects listed on it, but we'll take care of that in the next section.
126126

127127
### Registrar
128128

@@ -181,7 +181,7 @@ Depending on the speed of your Internet connection and machine, this may take on
181181

182182
### Linter CLI
183183

184-
In the section above we saw how the `tracker` is able to lint all repositories registered in the database. But sometimes it may be desirable to lint a single repository manually in an isolated way, maybe to quickly test some checks or to integrate with some other processes, like continuous integration or deployment tools. The `linter CLI` tool is designed to help in those scenarios.
184+
In the section above, we saw how the `tracker` is able to lint all repositories registered in the database. But sometimes, it may be desirable to lint a single repository manually in an isolated way, maybe to quickly test some checks or to integrate with some other processes, like continuous integration or deployment tools. The `linter CLI` tool is designed to help in those scenarios.
185185

186186
CLOMonitor delegates some of the security checks to [OpenSSF Scorecard](https://github.com/ossf/scorecard), so you'll need to [install it](https://github.com/ossf/scorecard#installation) before running `clomonitor-linter` locally. Both CLOMonitor and [OpenSSF Scorecard](https://github.com/ossf/scorecard) use the Github GraphQL API for some checks, which requires authentication. A Github token (with `public_repo` scope) **must** be provided via the `GITHUB_TOKEN` environment variable to authenticate those requests.
187187

@@ -205,7 +205,7 @@ cargo test
205205

206206
The CLOMonitor frontend is a single page application written in [TypeScript](https://www.typescriptlang.org) using [React](https://reactjs.org).
207207

208-
In the backend section we mentioned how to install the frontend dependencies and build it. That should be enough if you are only going to work on the backend. However, if you are planning to do some work on the frontend, it's better to launch an additional server which will rebuild the web application as needed whenever a file is modified.
208+
In the backend section, we mentioned how to install the frontend dependencies and build it. That should be enough if you are only going to work on the backend. However, if you are planning to do some work on the frontend, it's better to launch an additional server which will rebuild the web application as needed whenever a file is modified.
209209

210210
The frontend development server can be launched using the following command:
211211

docs/new-check.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ The **entrypoint** for the check must be a function named `check`, with the foll
1919
* Sync check: `pub(crate) fn check(input: &CheckInput) -> Result<CheckOutput<T>>`
2020
* Async check: `pub(crate) async fn check(input: &CheckInput<'_>) -> Result<CheckOutput<T>>`
2121

22-
In the [clomonitor-core/src/linter/checks/util](https://github.com/cncf/clomonitor/tree/main/clomonitor-core/src/linter/checks/util) directory there are some helpers that can be useful when writing new checks.
22+
In the [clomonitor-core/src/linter/checks/util](https://github.com/cncf/clomonitor/tree/main/clomonitor-core/src/linter/checks/util) directory, there are some helpers that can be useful when writing new checks.
2323

2424
### 2. Register the new check
2525

0 commit comments

Comments
 (0)