do not close connections in sync_to_async

Author: Swatinem

codecov/db/__init__.py

@@ -1,8 +1,6 @@
 import logging
 
-from asgiref.sync import SyncToAsync
 from django.conf import settings
-from django.db import close_old_connections
 from django.db.models import Field, Lookup
 
 log = logging.getLogger(__name__)
@@ -69,19 +67,3 @@ def as_sql(self, compiler, connection):
         rhs, rhs_params = self.process_rhs(compiler, connection)
         params = tuple(lhs_params) + tuple(rhs_params)
         return "%s is not %s" % (lhs, rhs), params
-
-
-class DatabaseSyncToAsync(SyncToAsync):
-    """
-    SyncToAsync version that cleans up old database connections.
-    """
-
-    def thread_handler(self, loop, *args, **kwargs):
-        close_old_connections()
-        try:
-            return super().thread_handler(loop, *args, **kwargs)
-        finally:
-            close_old_connections()
-
-
-sync_to_async = DatabaseSyncToAsync

codecov_auth/commands/owner/interactors/cancel_trial.py

@@ -1,8 +1,8 @@
+from asgiref.sync import sync_to_async
 from shared.plan.service import PlanService
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import Owner
 

codecov_auth/commands/owner/interactors/create_api_token.py

@@ -1,6 +1,7 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.models import Session
 
 

codecov_auth/commands/owner/interactors/create_stripe_setup_intent.py

@@ -1,10 +1,10 @@
 import logging
 
 import stripe
+from asgiref.sync import sync_to_async
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import Owner
 from services.billing import BillingService

codecov_auth/commands/owner/interactors/create_user_token.py

@@ -1,6 +1,7 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.models import UserToken
 
 

codecov_auth/commands/owner/interactors/delete_session.py

@@ -1,8 +1,8 @@
+from asgiref.sync import sync_to_async
 from django.contrib.sessions.models import Session as DjangoSession
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated
-from codecov.db import sync_to_async
 from codecov_auth.models import Session
 
 

codecov_auth/commands/owner/interactors/fetch_owner.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from codecov_auth.models import Owner
 
 

codecov_auth/commands/owner/interactors/get_org_upload_token.py

@@ -1,6 +1,7 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, Unauthorized
-from codecov.db import sync_to_async
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import OrganizationLevelToken
 

codecov_auth/commands/owner/interactors/get_uploads_number_per_user.py

@@ -1,10 +1,10 @@
 from typing import Optional
 
+from asgiref.sync import sync_to_async
 from shared.plan.service import PlanService
 from shared.upload.utils import query_monthly_coverage_measurements
 
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from codecov_auth.models import Owner
 from services.redis_configuration import get_redis_connection
 

codecov_auth/commands/owner/interactors/is_syncing.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from services.refresh import RefreshService
 
 

codecov_auth/commands/owner/interactors/onboard_user.py

@@ -1,8 +1,8 @@
+from asgiref.sync import sync_to_async
 from django import forms
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.models import OwnerProfile
 
 

codecov_auth/commands/owner/interactors/regenerate_org_upload_token.py

@@ -1,8 +1,9 @@
 import uuid
 
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import OrganizationLevelToken, Owner
 

codecov_auth/commands/owner/interactors/revoke_user_token.py

@@ -1,6 +1,7 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated
-from codecov.db import sync_to_async
 from codecov_auth.models import UserToken
 
 

codecov_auth/commands/owner/interactors/save_okta_config.py

@@ -1,10 +1,10 @@
 from dataclasses import dataclass
 
+from asgiref.sync import sync_to_async
 from shared.django_apps.codecov_auth.models import AccountsUsers, User
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.models import Account, OktaSettings, Owner
 
 

codecov_auth/commands/owner/interactors/save_terms_agreement.py

@@ -1,11 +1,11 @@
 from dataclasses import dataclass
 from typing import Any, Optional
 
+from asgiref.sync import sync_to_async
 from django.utils import timezone
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, ValidationError
-from codecov.db import sync_to_async
 from services.analytics import AnalyticsService
 
 

codecov_auth/commands/owner/interactors/set_upload_token_required.py

@@ -1,8 +1,9 @@
 from dataclasses import dataclass
 
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import Owner
 

codecov_auth/commands/owner/interactors/set_yaml_on_owner.py

@@ -2,6 +2,7 @@
 from typing import Optional
 
 import yaml
+from asgiref.sync import sync_to_async
 from shared.django_apps.core.models import Repository
 from shared.django_apps.utils.model_utils import get_ownerid_if_member
 from shared.validation.exceptions import InvalidYamlException
@@ -14,7 +15,6 @@
     Unauthorized,
     ValidationError,
 )
-from codecov.db import sync_to_async
 from codecov_auth.constants import OWNER_YAML_TO_STRING_KEY
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import Owner

codecov_auth/commands/owner/interactors/start_trial.py

@@ -1,8 +1,8 @@
+from asgiref.sync import sync_to_async
 from shared.plan.service import PlanService
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthorized, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.helpers import current_user_part_of_org
 from codecov_auth.models import Owner
 

codecov_auth/commands/owner/interactors/store_codecov_metric.py

@@ -1,12 +1,12 @@
 import json
 
+from asgiref.sync import sync_to_async
 from shared.django_apps.codecov_metrics.service.codecov_metrics import (
     UserOnboardingMetricsService,
 )
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.models import Owner
 
 

codecov_auth/commands/owner/interactors/tests/test_delete_session.py

@@ -1,9 +1,9 @@
 import pytest
+from asgiref.sync import sync_to_async
 from django.test import TestCase
 from shared.django_apps.codecov_auth.tests.factories import OwnerFactory, SessionFactory
 
 from codecov.commands.exceptions import Unauthenticated
-from codecov.db import sync_to_async
 from codecov_auth.models import DjangoSession, Session
 from codecov_auth.tests.factories import DjangoSessionFactory
 

codecov_auth/commands/owner/interactors/tests/test_revoke_user_token.py

@@ -1,12 +1,12 @@
 import pytest
+from asgiref.sync import sync_to_async
 from django.test import TestCase
 from shared.django_apps.codecov_auth.tests.factories import (
     OwnerFactory,
     UserTokenFactory,
 )
 
 from codecov.commands.exceptions import Unauthenticated
-from codecov.db import sync_to_async
 from codecov_auth.models import UserToken
 
 from ..revoke_user_token import RevokeUserTokenInteractor

codecov_auth/commands/owner/interactors/tests/test_set_yaml_on_owner.py

@@ -1,4 +1,5 @@
 import pytest
+from asgiref.sync import sync_to_async
 from django.test import TestCase
 from shared.django_apps.core.tests.factories import OwnerFactory, RepositoryFactory
 
@@ -8,7 +9,6 @@
     Unauthorized,
     ValidationError,
 )
-from codecov.db import sync_to_async
 
 from ..set_yaml_on_owner import SetYamlOnOwnerInteractor
 

codecov_auth/commands/owner/interactors/trigger_sync.py

@@ -1,6 +1,7 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated
-from codecov.db import sync_to_async
 from services.refresh import RefreshService
 
 

codecov_auth/commands/owner/interactors/update_default_organization.py

@@ -1,8 +1,9 @@
 from typing import Optional
 
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, ValidationError
-from codecov.db import sync_to_async
 from codecov_auth.models import Owner, OwnerProfile
 from services.activation import try_auto_activate
 

codecov_auth/commands/owner/interactors/update_profile.py

@@ -1,8 +1,8 @@
+from asgiref.sync import sync_to_async
 from django import forms
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, ValidationError
-from codecov.db import sync_to_async
 
 
 class UpdateProfileForm(forms.Form):

codecov_auth/commands/owner/interactors/update_self_hosted_settings.py

@@ -1,11 +1,11 @@
 from dataclasses import dataclass
 
+from asgiref.sync import sync_to_async
 from django.conf import settings
 
 import services.self_hosted as self_hosted
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import Unauthenticated, ValidationError
-from codecov.db import sync_to_async
 
 
 @dataclass

core/commands/branch/interactors/fetch_branch.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 
 
 class FetchBranchInteractor(BaseInteractor):

core/commands/branch/interactors/fetch_branches.py

@@ -1,10 +1,10 @@
 from typing import Any
 
+from asgiref.sync import sync_to_async
 from django.db.models import OuterRef, Q, QuerySet, Subquery
 from shared.django_apps.core.models import Repository
 
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from core.models import Commit
 
 

core/commands/commit/interactors/fetch_totals.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 
 
 class FetchTotalsInteractor(BaseInteractor):

core/commands/commit/interactors/get_commit_errors.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from graphql_api.types.enums import CommitErrorCode, CommitErrorGeneralType
 
 

core/commands/commit/interactors/get_final_yaml.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from services.yaml import final_commit_yaml
 
 

core/commands/commit/interactors/get_latest_upload_error.py

@@ -1,8 +1,9 @@
 import logging
 from typing import Optional
 
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from core.models import Commit
 from reports.models import CommitReport, UploadError
 

core/commands/commit/interactors/get_uploads_number.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 
 
 class GetUploadsNumberInteractor(BaseInteractor):

core/commands/pull/interactors/fetch_pull_request.py

@@ -1,9 +1,9 @@
 from datetime import datetime, timedelta
 
+from asgiref.sync import sync_to_async
 from shared.django_apps.core.models import Pull, Repository
 
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 from services.task.task import TaskService
 
 

core/commands/pull/interactors/fetch_pull_requests.py

@@ -1,5 +1,6 @@
+from asgiref.sync import sync_to_async
+
 from codecov.commands.base import BaseInteractor
-from codecov.db import sync_to_async
 
 
 class FetchPullRequestsInteractor(BaseInteractor):

core/commands/repository/interactors/activate_measurements.py

@@ -1,8 +1,8 @@
+from asgiref.sync import sync_to_async
 from django.conf import settings
 
 from codecov.commands.base import BaseInteractor
 from codecov.commands.exceptions import ValidationError
-from codecov.db import sync_to_async
 from timeseries.helpers import trigger_backfill
 from timeseries.models import Dataset, MeasurementName