Refator: Memoize variables and make codes Rubyish

Author: yasulab

app/controllers/podcasts_controller.rb

@@ -16,9 +16,10 @@ def show
   end
 
   def feed
-    @episodes   = Podcast.all.sort_by{|episode| episode.published_at}
-    @domainname = request.base_url
-    @author     = "一般社団法人 CoderDojo Japan"
+    @episodes     = Podcast.all.sort_by{|episode| episode.published_at}
+    @base_url     = request.base_url
+    @author       = "一般社団法人 CoderDojo Japan"
+    @current_year = Time.current.year
     respond_to do |format|
       format.rss { render :layout => false }
     end

app/models/podcast.rb

@@ -51,7 +51,7 @@ def description
   end
 
   def published_at
-    @pubDate ||= exists? ? Time.parse(self.content.lines.second.gsub(/<.+?>/, '').delete('収録日: ')) : ''
+    @published_at ||= exists? ? Time.parse(self.content.lines.second.gsub(/<.+?>/, '').delete('収録日: ')) : ''
   end
 
   def content

app/views/podcasts/feed.rss.builder

@@ -1,30 +1,34 @@
 xml.instruct! :xml, :version => "1.0"
 xml.rss :version => "2.0", "xmlns:itunes" => "http://www.itunes.com/dtds/Podcast-1.0.dtd" do
   xml.channel do
-    xml.title full_title ""
+    xml.title       full_title ""
     xml.description full_description ""
-    xml.link root_url
-    xml.author @author
-    xml.copyright "Copyright © 2012-2018 一般社団法人 CoderDojo Japan"
-    xml.language "ja"
+    xml.link        root_url
+    xml.author      @author
+    xml.copyright   "Copyright © 2012-#{@current_year} #{@author}"
+    xml.language    "ja"
     xml.itunes :category, :text => "Technology" do
       xml.itunes :category, :text => "Software How-To"
       xml.itunes :category, :text => "Podcasting"
     end
-    xml.itunes :type, "serial"
+    xml.itunes :type,     "serial"
     xml.itunes :explicit, "clean"
 
     @episodes.each do |episode|
       xml.item do
-        xml.title episode.title
-        xml.author @author
-        xml.description episode.description
-        xml.link @domainname + episode.url
-        xml.guid({:isPermaLink => "false"}, @domainname + episode.url)
-        xml.itunes :explicit, "clean"
-        xml.pubDate episode.published_at.rfc2822
-        xml.enclosure({:url => @domainname + episode.url + ".mp3", :length => episode.filesize, :type => "audio/mpeg"})
-        xml.itunes :duration, episode.duration
+        xml.title        episode.title
+        xml.author       @author
+        xml.description  episode.description
+        xml.link         "#{@base_url}#{episode.url}"
+        xml.guid({:isPermaLink => "false"}, "#{@base_url}#{episode.url}")
+        xml.itunes       :explicit, "clean"
+        xml.published_at episode.published_at.rfc2822
+        xml.enclosure({
+	  :url    => "#{@base_url}#{episode.url}.mp3",
+	  :length => episode.filesize,
+	  :type   => "audio/mpeg"}
+	)
+        xml.itunes       :duration, episode.duration
       end
     end
   end