Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is performance issue on $.isEmpty #1095

Closed
tasuku-s opened this issue Apr 7, 2020 · 1 comment
Closed

There is performance issue on $.isEmpty #1095

tasuku-s opened this issue Apr 7, 2020 · 1 comment
Labels
bug

Comments

@tasuku-s
Copy link
Contributor

tasuku-s commented Apr 7, 2020

In my usecase (Angular, many editor, long text in a block), copy, paste and click any line in block that has too long lines makes browser freezing.

I found that isEmpty method in editor.js/src/components/dom.ts has bad algorithm to traverse nodes.

When there are nodes like A, B, C, D, E, then this method traverse nodes as A, B, C, D, E, B, C, D, E, C, D, E, D, E.
@tasuku-s tasuku-s mentioned this issue Apr 7, 2020
Merged
@neSpecc neSpecc mentioned this issue Jun 2, 2020
Merged
@gohabereg
Copy link
Member

Resolved by #1096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neSpecc @tasuku-s @gohabereg