New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡Add generics to OutputBlockData #1551

Closed

hata6502 opened this issue Feb 20, 2021 · 0 comments

Contributor

hata6502 commented Feb 20, 2021

Describe a problem.
By using Generics, Editor.js users can describe string literal types.

https://www.typescriptlang.org/docs/handbook/literal-types.html#string-literal-types

By using string literal types in OutputBlockData['type'], Editor.js users can describe more type-safe OutputData in each application.

Describe the solution you'd like. Mockups are welcome.
See:
https://github.com/hata6502/editorjs-examples/blob/main/examples/ExampleEditorJSData.ts#L17

hata6502 added the feature label

hata6502 mentioned this issue

Add generics to OutputBlockData #1326

Merged

hata6502 closed this as completed

neSpecc mentioned this issue

Release 2.19.2 #1597

Merged

dependabot bot mentioned this issue

chore(deps): bump @editorjs/editorjs from 2.19.1 to 2.19.3 jameslahm/ss-reddit#185

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment