Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Toolbar after Link insertion #600

Closed
neSpecc opened this issue Jan 24, 2019 · 7 comments
Closed

Close Toolbar after Link insertion #600

neSpecc opened this issue Jan 24, 2019 · 7 comments

Comments

@neSpecc
Copy link
Member

neSpecc commented Jan 24, 2019

  1. Select fragment of text
  2. Click on Link Tool at the Inline Toolbar (or press CMD+K)
  3. Enter or paste a link and press Enter
  4. Link will be inserted, but Inline Toolbar still opened

We need to close the Inline Toolbar after link insertion

@tanmayv
Copy link

tanmayv commented Apr 9, 2019

Regarding this issue, on pressing enter we want the inline-toolbar to close?

@neSpecc
Copy link
Member Author

neSpecc commented Apr 9, 2019

@tanmayv yes

@tanmayv
Copy link

tanmayv commented Apr 9, 2019

I was thinking of closing the inlineToolbar whenever we call Toolbar.close() or we can expose InlineToolbar to API as well and the close it manually as well from the inline-tools. What would you suggest?

@neSpecc
Copy link
Member Author

neSpecc commented Apr 9, 2019

You can directly call this.Editor.InlineToolbar.close(); at the specific moment

@neSpecc
Copy link
Member Author

neSpecc commented Apr 9, 2019

Sorry, you are right, it’s better to use an API, because it is a logic of the inline link tool, not an editor core module

@neSpecc
Copy link
Member Author

neSpecc commented Apr 9, 2019

@tanmayv probably, this task better do after #665

@neSpecc
Copy link
Member Author

neSpecc commented Apr 11, 2019

@tanmayv Inline Toolbar API now available at the release/2.13 branch, so create a branch based on it. And PR should be opened to that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants