record and release old wgpu BindGroup items, which were otherwise not being released. thanks to @AnyCPU for identifying leak and potential fix, and @StinkyPeach for reporting the issue.

Author: rcoreilly

gpu/compute.go

@@ -157,6 +157,7 @@ func (sy *ComputeSystem) EndComputePass() error {
 	sy.device.Queue.Submit(cmdBuffer)
 	cmdBuffer.Release()
 	cmd.Release()
+	sy.vars.releaseOldBindGroups()
 	return nil
 }
 

gpu/gpudraw/draw.go

@@ -39,7 +39,7 @@ func (dw *Drawer) Copy(dp image.Point, src image.Image, sr image.Rectangle, op d
 		dr := sr
 		del := dp.Sub(sr.Min)
 		dr.Min = dp
-		dr.Max.Add(del)
+		dr.Max = dr.Max.Add(del)
 		dw.Fill(u.At(0, 0), dr, op)
 		return
 	}

gpu/gsystem.go

@@ -269,6 +269,7 @@ func (sy *GraphicsSystem) SubmitRender(rp *wgpu.RenderPassEncoder) error {
 	sy.device.Queue.Submit(cmdBuffer)
 	cmdBuffer.Release()
 	cmd.Release()
+	sy.vars.releaseOldBindGroups()
 	return nil
 }
 

gpu/pipeline.go

@@ -131,3 +131,12 @@ func (pl *Pipeline) bindLayout() (*wgpu.PipelineLayout, error) {
 	}
 	return rpl, nil
 }
+
+func (pl *Pipeline) releaseOldBindGroups() {
+	vs := pl.Vars()
+	ngp := vs.NGroups()
+	for gi := range ngp {
+		vg := vs.Groups[gi]
+		vg.releaseOldBindGroups()
+	}
+}

gpu/value.go

@@ -279,7 +279,7 @@ func (vl *Value) SetFromBytes(from []byte) error {
 		return errors.Log(err)
 	}
 	if vl.buffer == nil || vl.AllocSize != tb {
-		vl.varGroupDirty()
+		vl.varGroupDirty() // only if tb is different; buffer created in bindGroupEntry so not nil here
 		vl.Release()
 		buf, err := vl.device.Device.CreateBufferInit(&wgpu.BufferInitDescriptor{
 			Label:    vl.Name,
@@ -355,7 +355,7 @@ func (vl *Value) WriteDynamicBuffer() error {
 		return errors.Log(err)
 	}
 	if vl.buffer == nil || nb != vl.AllocSize {
-		vl.varGroupDirty()
+		vl.varGroupDirty() // only if nb is different; buffer created in bindGroupEntry so not nil here
 		vl.Release()
 		buf, err := vl.device.Device.CreateBufferInit(&wgpu.BufferInitDescriptor{
 			Label:    vl.Name,

gpu/vargroup.go

@@ -66,6 +66,10 @@ type VarGroup struct {
 
 	// current bind group
 	currentBindGroup *wgpu.BindGroup
+
+	// oldBindGroups are prior bind groups that need to be released
+	// after current render or compute pass.
+	oldBindGroups []*wgpu.BindGroup
 }
 
 // addVar adds given variable
@@ -223,8 +227,21 @@ func (vg *VarGroup) Config(dev *Device) error {
 	return errors.Join(errs...)
 }
 
+// releaseOldBindGroups releases old bind groups.
+func (vg *VarGroup) releaseOldBindGroups() {
+	if vg.oldBindGroups == nil {
+		return
+	}
+	og := vg.oldBindGroups
+	vg.oldBindGroups = nil
+	for _, bg := range og {
+		bg.Release()
+	}
+}
+
 // Release destroys infrastructure for Group, Vars and Values.
 func (vg *VarGroup) Release() {
+	vg.releaseOldBindGroups()
 	for _, vr := range vg.Vars {
 		vr.Release()
 	}
@@ -318,7 +335,10 @@ func (vg *VarGroup) bindGroup(vs *Vars) (*wgpu.BindGroup, []uint32, error) {
 		return vg.currentBindGroup, dynamicOffsets, nil
 	}
 	vg.bindGroupDirty = false
-	vg.currentBindGroup = nil // critically, we do NOT release this!
+	if vg.currentBindGroup != nil {
+		vg.oldBindGroups = append(vg.oldBindGroups, vg.currentBindGroup) // to be released
+	}
+	vg.currentBindGroup = nil
 	bgl, err := vg.bindLayout(vs)
 	if err != nil {
 		return nil, nil, err

gpu/vars.go

@@ -48,6 +48,12 @@ func (vs *Vars) Release() {
 	}
 }
 
+func (vs *Vars) releaseOldBindGroups() {
+	for _, vg := range vs.Groups {
+		vg.releaseOldBindGroups()
+	}
+}
+
 // AddVertexGroup adds a new Vertex Group.
 // This is a special Group holding Vertex, Index vars
 func (vs *Vars) AddVertexGroup() *VarGroup {