fix(getlocation): dont add empty string or object to query string

Author: colinmeinke

src/helpers/getLocation.js

@@ -109,14 +109,22 @@ const getQueryString = query => {
         const objParts = Object.keys( query[ k ]).map( objKey => {
           const key = encode( `${ k }[${ objKey }]` );
           const value = encode( query[ k ][ objKey ]);
-          return `${ key }=${ value }`;
-        });
 
-        return objParts.length ? `${ objParts.join( '&' )}` : '';
+          if ( value.length ) {
+            return `${ key }=${ value }`;
+          }
+
+          return null;
+        }).filter( part => part !== null );
+
+        return objParts.length ? `${ objParts.join( '&' )}` : null;
       } else {
         const key = encode( `${ k }` );
         const value = encode( query[ k ]);
-        return `${ key }=${ value }`;
+
+        if ( value.length ) {
+          return `${ key }=${ value }`;
+        }
       }
 
       return null;

test/helpers/getLocation.js

@@ -134,6 +134,18 @@ describe( 'helper', () => {
       expect( getQueryString( query )).toBe( expectedQueryString );
     });
 
+    it( 'should work with an query item that has an empty value', () => {
+      const query = { foo: '' };
+      const expectedQueryString = '';
+      expect( getQueryString( query )).toBe( expectedQueryString );
+    });
+
+    it( 'should work with an query item that is an object and has an empty value', () => {
+      const query = { foo: { bar: '' }};
+      const expectedQueryString = '';
+      expect( getQueryString( query )).toBe( expectedQueryString );
+    });
+
     it( 'should encode special characters', () => {
       const query = { test: 'Rock & Roll' };
       const expectedQueryString = '?test=Rock+%26+Roll';