The app erroneously shows successfully uploaded images as "Failed" #5280
Comments
|
I had not experienced this in a long time, but I just got this when testing #5399 https://commons.wikimedia.org/wiki/File:Buildings_around_Nihonbashi_12.jpg
|
|
This is supposed to be a rare issue; the connectivity going off exactly at that point shouldn't happen frequently. I'll test that branch more to check if there's an increase in the frequency of this problem occurring. |
|
I am sure there is nothing wrong with that branch. it is just because I cut the Internet while uploading, for test purposes. |
|
I can still reproduce this in main, though it took 200 uploads in total over a few days. When I managed to reproduce this morning, I had uploading in parallel about four 20-pictures multi-uploads. Could be linked to me taking the elevator. Explanation of the screencast below: One of the many pictures, despite having been uploaded successfully (as proved by the Commons website) and not being special in content nor metadata, is considered by the app as having failed. Retrying does not make the app "realize its mistake". screen-20240304-114113.mp4 |
|
I just had something similar with a pic uploaded via the Nearby activity. After upload it looked like this (Adidas pic at the top):
Now the same pic shows up as "Queued" then "Failed" every time I start the app. It is actually uploaded: https://commons.m.wikimedia.org/wiki/File:Adidas_Futsal_Park.jpg
It might actually be a different issue? |
|
@nicolas-raoul, does it show up in the logcat? |
|
I unfortunately rebooted and thus have no logcat of the upload itself, but I can take a logcat of the queued/failed if you think that's useful. |
|
As far as I remember, the logcat used to provide significantly useful details everytime the upload failed due to any exception (including retries). So, it might be useful. |
|
Here is the logcat when upload fails (with picture actually already present on the server): |
|
Half-failed images now do not show as failed anymore (which is good because there is less risk of re-upload). |
Summary
The app erroneously shows successfully uploaded images as "Failed". If the user taps on the retry button (or if it is retried automatically by the app), then the image gets uploaded again. The first upload, however, often lacks caption and/or depiction. This happens probably because Wikidata edit is unsuccessful for such uploads.
Related: This commit tried to forbid retries in such cases and showed the upload as successful in the Contributions list. However, the media details fragment became unreliable; it displayed the Coordinates as
None Provided, Description as{{en|1=Ikuchijima}}etc.Steps to reproduce
Hard to reproduce. A deliberate way of reproducing it:
PageContentsCreatorExpected behaviour
The app should upload the image reliably without losing data or adding duplicates to the server.
Actual behaviour
The app shows the image as "Failed" and uploads it again.
Device name
Redmi 5A
Android version
8.1.0
Commons app version
master and prodDebug
Device logs
No response
Screen-shots
No response
Would you like to work on the issue?
None
The text was updated successfully, but these errors were encountered: