Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom image selector: Do not reload everything after marking a picture as not for upload #5558

Closed
nicolas-raoul opened this issue Feb 17, 2024 · 4 comments · Fixed by #5576

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 17, 2024

How to reproduce the issue:

  1. In the custom image selector, mark your first 100 pictures as not for upload, then disable "Show already actioned pictures".
  2. (screencast below starts at this step) In the custom image selector, tap one picture.
  3. Tap "Mark as not for upload"

Expected: Only the selected picture diapsears from the screen. The remaining pictures move up a bit, one additional picture gets shown at the bottom.

Actually: All pictures disappear from the screen, the activity gets reloaded fully which takes a lot of time (about 20 seconds in the screencast below).

screen-20240217-133032.mp4
@shashankiitbhu
Copy link
Contributor

I would like to work on this @nicolas-raoul

@nicolas-raoul
Copy link
Member Author

Thanks @shashankiitbhu! Do not hesitate to ask if anything is unclear.

@shashankiitbhu
Copy link
Contributor

Hi @nicolas-raoul I have solved this issue but I am waiting for #5571 to get fixed (which I have solved locally and can make a separate PR to fix it as I have already asked in the discussion going on there)

WhatsApp.Video.2024-02-29.at.7.21.14.PM.mp4

@shashankiitbhu
Copy link
Contributor

@nicolas-raoul Added the above PR to fix this issue, please review, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants