Skip to content

Commit 809fc86

Browse files
Rollup merge of rust-lang#100468 - cuviper:lazy-x, r=jyn514
Use an extensionless `x` script for non-Windows rust-lang#99992 added `x.sh` and `x.ps1`, but this broke my lazy `./xTAB` habit that used to get me to `./x.py`. If we rename `x.sh` to `x`, then I can adjust to `./xSPACE` for the same number of characters typed. r? `@jyn514`
2 parents 86e1d1e + de8dedb commit 809fc86

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

src/bootstrap/mk/Makefile.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ TESTS_IN_MINGW_2 := \
8080
src/test/ui
8181

8282
ci-mingw-subset-1:
83-
$(Q)$(CFG_SRC_DIR)/x.sh test --stage 2 $(TESTS_IN_MINGW_2:%=--exclude %)
83+
$(Q)$(CFG_SRC_DIR)/x test --stage 2 $(TESTS_IN_MINGW_2:%=--exclude %)
8484
ci-mingw-subset-2:
8585
$(Q)$(BOOTSTRAP) test --stage 2 $(TESTS_IN_MINGW_2)
8686

src/ci/docker/host-x86_64/x86_64-gnu-llvm-12/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ ENV RUST_CONFIGURE_ARGS \
4444
--enable-llvm-link-shared \
4545
--set rust.thin-lto-import-instr-limit=10
4646

47-
# NOTE: intentionally uses all of `x.py`, `x.sh`, and `x.ps1` to make sure they all work on Linux.
47+
# NOTE: intentionally uses all of `x.py`, `x`, and `x.ps1` to make sure they all work on Linux.
4848
ENV SCRIPT ../x.py --stage 2 test --exclude src/tools/tidy && \
4949
# Run the `mir-opt` tests again but this time for a 32-bit target.
5050
# This enforces that tests using `// EMIT_MIR_FOR_EACH_BIT_WIDTH` have
5151
# both 32-bit and 64-bit outputs updated by the PR author, before
5252
# the PR is approved and tested for merging.
5353
# It will also detect tests lacking `// EMIT_MIR_FOR_EACH_BIT_WIDTH`,
5454
# despite having different output on 32-bit vs 64-bit targets.
55-
../x.sh --stage 2 test src/test/mir-opt \
55+
../x --stage 2 test src/test/mir-opt \
5656
--host='' --target=i686-unknown-linux-gnu && \
5757
# Run the UI test suite again, but in `--pass=check` mode
5858
#

src/tools/tidy/src/bins.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ mod os_impl {
9898
pub fn check(path: &Path, bad: &mut bool) {
9999
use std::ffi::OsStr;
100100

101-
const ALLOWED: &[&str] = &["configure"];
101+
const ALLOWED: &[&str] = &["configure", "x"];
102102

103103
crate::walk_no_read(
104104
path,

x.sh x

File renamed without changes.

x.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env pwsh
22

3-
# See x.sh for why these scripts exist.
3+
# See ./x for why these scripts exist.
44

55
$xpy = Join-Path $PSScriptRoot x.py
66
# Start-Process for some reason splits arguments on spaces. (Isn't powershell supposed to be simpler than bash?)

x.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env python3
22
# Some systems don't have `python3` in their PATH. This isn't supported by x.py directly;
3-
# they should use `x.sh` or `x.ps1` instead.
3+
# they should use `x` or `x.ps1` instead.
44

55
# This file is only a "symlink" to bootstrap.py, all logic should go there.
66

0 commit comments

Comments
 (0)