From 9d2bd304022187274b67ea32d139b34fe5b10fc5 Mon Sep 17 00:00:00 2001 From: Vikram Kalta <65945391+vkalta@users.noreply.github.com> Date: Wed, 26 Feb 2025 11:27:05 +0000 Subject: [PATCH 1/3] fix: variants types fixes (#278) Co-authored-by: Vikram Kalta --- test/typescript/variants.ts | 2 -- types/stack/VariantGroup/index.ts | 6 +++--- types/stack/VariantGroup/variants/index.d.ts | 4 ++-- types/stack/index.d.ts | 6 +++--- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/test/typescript/variants.ts b/test/typescript/variants.ts index 84b8ffcc..6f7a350d 100644 --- a/test/typescript/variants.ts +++ b/test/typescript/variants.ts @@ -1,7 +1,5 @@ import { expect } from "chai" -import path from "path" import { Stack } from "../../types/stack"; -import { Variant, Variants } from "../../types/stack/VariantGroup/variants"; import { variantEntry, variantEntry2 } from "./mock/variants"; var tokenUID = '' export function createVariant(stack: Stack) { diff --git a/types/stack/VariantGroup/index.ts b/types/stack/VariantGroup/index.ts index fe09fee5..7448edce 100644 --- a/types/stack/VariantGroup/index.ts +++ b/types/stack/VariantGroup/index.ts @@ -1,10 +1,10 @@ import { AnyProperty, SystemFields } from "../../utility/fields"; import { Queryable, SystemFunction } from "../../utility/operations"; -import { Variants, Variant } from "./variants"; +import { VariantGroupVariants, VariantGroupVariant } from "./variants"; export interface VariantGroup extends SystemFields, SystemFunction { - variants(): Variants - variants(variant: string): Variant + variants(): VariantGroupVariants + variants(variant: string): VariantGroupVariant } export interface VariantGroups extends Queryable { diff --git a/types/stack/VariantGroup/variants/index.d.ts b/types/stack/VariantGroup/variants/index.d.ts index c5c1d358..a30b29a8 100644 --- a/types/stack/VariantGroup/variants/index.d.ts +++ b/types/stack/VariantGroup/variants/index.d.ts @@ -1,11 +1,11 @@ import { AnyProperty, SystemFields } from "../../../utility/fields"; import { Queryable, SystemFunction } from "../../../utility/operations"; -export interface Variant extends SystemFields, SystemFunction { +export interface VariantGroupVariant extends SystemFields, SystemFunction { } -export interface Variants extends Queryable { +export interface VariantGroupVariants extends Queryable { } diff --git a/types/stack/index.d.ts b/types/stack/index.d.ts index dee357d1..2ee9d273 100644 --- a/types/stack/index.d.ts +++ b/types/stack/index.d.ts @@ -22,7 +22,7 @@ import { Taxonomy, Taxonomies } from "./taxonomy"; import { ManagementToken, ManagementTokens } from "./managementToken"; import { Variant, Variants } from "./variants"; import { VariantGroup, VariantGroups } from "./VariantGroup"; -import { Variant, Variants } from "./VariantGroup/variants"; +import { VariantGroupVariant, VariantGroupVariants } from "./VariantGroup/variants"; export interface StackConfig { api_key:string @@ -112,6 +112,6 @@ export interface Stack extends SystemFields { variantGroup(): VariantGroups variantGroup(uid: string): VariantGroup - variant(): Variants - variant(uid: string): Variant + variant(): VariantGroupVariants + variant(uid: string): VariantGroupVariant } From a539a2368ecc259a62dd9936c750c873a231422d Mon Sep 17 00:00:00 2001 From: "harshitha.d" Date: Mon, 3 Mar 2025 18:35:11 +0530 Subject: [PATCH 2/3] fix: exclude stackHeaders from entry data assignment --- lib/stack/contentType/entry/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/stack/contentType/entry/index.js b/lib/stack/contentType/entry/index.js index 6bcef110..c1c41b85 100644 --- a/lib/stack/contentType/entry/index.js +++ b/lib/stack/contentType/entry/index.js @@ -29,7 +29,8 @@ export function Entry (http, data) { if (this.apiVersion && !this.stackHeaders.api_version) { this.stackHeaders.api_version = this.apiVersion; } - Object.assign(this, cloneDeep(data.entry)) + const { stackHeaders, ...entryData } = data.entry; + Object.assign(this, cloneDeep(entryData)) this.urlPath = `/content_types/${this.content_type_uid}/entries/${this.uid}` /** From be4eeef60fcd51ad2fb59d3d62eb43aa702c29bf Mon Sep 17 00:00:00 2001 From: "harshitha.d" Date: Wed, 5 Mar 2025 15:03:18 +0530 Subject: [PATCH 3/3] bump version to 1.19.4 and update changelog with variants import fix --- CHANGELOG.md | 8 +++++++- package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 634e1188..97aa0f12 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog -## [v1.19.3](https://github.com/contentstack/contentstack-management-javascript/tree/v1.19.2) (2025-02-24) + +## [v1.19.4](https://github.com/contentstack/contentstack-management-javascript/tree/v1.19.4) (2025-03-10) + - Fix + - added fix for variants import + - excludec stackHeaders from entry data assignment + +## [v1.19.3](https://github.com/contentstack/contentstack-management-javascript/tree/v1.19.3) (2025-02-24) - Fix - Added proper assertions for test cases diff --git a/package-lock.json b/package-lock.json index df4bb759..6b854fbb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@contentstack/management", - "version": "1.19.3", + "version": "1.19.4", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@contentstack/management", - "version": "1.19.3", + "version": "1.19.4", "license": "MIT", "dependencies": { "axios": "^1.7.9", diff --git a/package.json b/package.json index 8382f288..15a30e2d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@contentstack/management", - "version": "1.19.3", + "version": "1.19.4", "description": "The Content Management API is used to manage the content of your Contentstack account", "main": "./dist/node/contentstack-management.js", "browser": "./dist/web/contentstack-management.js",