Skip to content

Commit bbab1d8

Browse files
authored
fix(core): deprecate nlp rules
closed #54
1 parent 504bca2 commit bbab1d8

17 files changed

+103
-831
lines changed

@commitlint/config-angular/index.js

-4
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
module.exports = {
22
rules: {
33
'body-leading-blank': [1, 'always'],
4-
'body-tense': [1, 'always', ['present-imperative']],
54
'footer-leading-blank': [1, 'always'],
6-
'footer-tense': [1, 'always', ['present-imperative']],
75
'header-max-length': [2, 'always', 72],
8-
lang: [1, 'always', 'eng'],
96
'scope-case': [2, 'always', 'lowerCase'],
107
'subject-empty': [2, 'never'],
118
'subject-full-stop': [2, 'never', '.'],
12-
'subject-tense': [1, 'always', ['present-imperative']],
139
'type-case': [2, 'always', 'lowerCase'],
1410
'type-empty': [2, 'never'],
1511
'type-enum': [

@commitlint/core/package.json

-2
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,8 @@
9090
"conventional-commits-parser": "^1.3.0",
9191
"cosmiconfig": "^3.0.1",
9292
"find-up": "^2.1.0",
93-
"franc": "^2.0.0",
9493
"lodash": "^4.17.4",
9594
"path-exists": "^3.0.0",
96-
"pos": "^0.4.2",
9795
"resolve-from": "^3.0.0",
9896
"semver": "^5.3.0"
9997
}

@commitlint/core/src/library/ensure-language.js

-18
This file was deleted.

@commitlint/core/src/library/ensure-language.test.js

-63
This file was deleted.

@commitlint/core/src/library/ensure-tense.js

-68
This file was deleted.

@commitlint/core/src/library/ensure-tense.test.js

-59
This file was deleted.

@commitlint/core/src/lint.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@ export default async (message, rules = {}, opts = {}) => {
4343
})
4444
.filter(Boolean);
4545

46-
const errors = results.filter(result => result.level > 1 && !result.valid);
47-
48-
const warnings = results.filter(result => result.level < 2 && !result.valid);
46+
const errors = results.filter(result => result.level === 2 && !result.valid);
47+
const warnings = results.filter(
48+
result => result.level === 1 && !result.valid
49+
);
4950

5051
const valid = errors.length === 0;
5152

@@ -55,4 +56,3 @@ export default async (message, rules = {}, opts = {}) => {
5556
warnings
5657
};
5758
};
58-
+2-19
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,6 @@
1-
import ensureTense from '../library/ensure-tense';
2-
import message from '../library/message';
3-
41
export default (parsed, when, value) => {
5-
const tenses = Array.isArray(value) ? value : value.allowed || [];
6-
const ignoreConfig = Array.isArray(value) ? [] : value.ignored || [];
7-
8-
const negated = when === 'never';
9-
const ignored = [...ignoreConfig, ...parsed.notes.map(note => note.title)];
10-
const {matches, offending} = ensureTense(parsed.body, tenses, {ignored});
11-
const offenders = offending
12-
.map(item => [item.lemma, item.tense].join(' - '))
13-
.join(',');
14-
152
return [
16-
negated ? !matches : matches,
17-
message([
18-
`tense of body must`,
19-
negated ? `not` : null,
20-
`be ${value}. Verbs in other tenses: ${offenders}`
21-
])
3+
false,
4+
`rules.body-tense is deprecated. Received [${when}, [${value.join(', ')}]]`
225
];
236
};

0 commit comments

Comments
 (0)