Skip to content

Commit e3a78bc

Browse files
committed
fix(core): use correct report message #192
1 parent 949579c commit e3a78bc

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

@commitlint/core/src/rules/subject-case.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ export default (parsed, when, value) => {
2929

3030
return [
3131
negated(when) ? !result : result,
32-
message([`subject must`, negated ? `not` : null, `be ${list}`])
32+
message([`subject must`, negated(when) ? `not` : null, `be ${list}`])
3333
];
3434
};

@commitlint/core/src/rules/subject-case.test.js

+18
Original file line numberDiff line numberDiff line change
@@ -251,3 +251,21 @@ test('with startcase subject should succeed for "always startcase"', async t =>
251251
const expected = true;
252252
t.is(actual, expected);
253253
});
254+
255+
test('should use expected message with "always"', async t => {
256+
const [, message] = subjectCase(
257+
await parsed.uppercase,
258+
'always',
259+
'lower-case'
260+
);
261+
t.true(message.indexOf('must be lower-case') > -1);
262+
});
263+
264+
test('should use expected message with "never"', async t => {
265+
const [, message] = subjectCase(
266+
await parsed.uppercase,
267+
'never',
268+
'upper-case'
269+
);
270+
t.true(message.indexOf('must not be upper-case') > -1);
271+
});

0 commit comments

Comments
 (0)