Skip to content

Commit 7200967

Browse files
committed
converse-chatboxes: Don't refetch chatboxes upon reconnection
We don't remove the existing chatboxes and upon refetching they become stale and get removed (by Backbone) and then the UI for them becomes unresponsive.
1 parent c0ef008 commit 7200967

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/headless/converse-chatboxes.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,10 @@ converse.plugins.add('converse-chatboxes', {
10511051
_converse.api.trigger('chatBoxesFetched');
10521052
},
10531053

1054-
onConnected () {
1054+
onConnected (reconnecting) {
1055+
if (reconnecting) {
1056+
return;
1057+
}
10551058
const storage = _converse.config.get('storage');
10561059
this.browserStorage = new BrowserStorage[storage](
10571060
`converse.chatboxes-${_converse.bare_jid}`);
@@ -1265,7 +1268,7 @@ converse.plugins.add('converse-chatboxes', {
12651268
_converse.api.trigger('chatBoxesInitialized');
12661269
});
12671270

1268-
_converse.api.listen.on('presencesInitialized', () => _converse.chatboxes.onConnected());
1271+
_converse.api.listen.on('presencesInitialized', (reconnecting) => _converse.chatboxes.onConnected(reconnecting));
12691272
_converse.api.listen.on('reconnected', () => _converse.chatboxes.forEach(m => m.onReconnection()));
12701273
/************************ END Event Handlers ************************/
12711274

0 commit comments

Comments
 (0)