-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing in MUC shows "Typing from another device" #1026
Comments
What server are you using? Is there a MUC where I can test this? I haven't seen this myself yet. The code naively assumes any incoming CSN messages are from other devices. |
I've tested it with a self-hosted 3.3.3 on the prosody MUC ([email protected]) and on another MUC running on chat.yax.im. |
I just tested with the Prosody MUC and can confirm that I received I remember there already being a check for message IDs to filter out dupes, so this makes sense to me. Are you able to replicate reliably? |
I too see this, using mod_conversejs on my development Prosody. |
I'm seeing the same thing in an Openfire-based MUC. |
I've disabled the |
Reopening since I realised we can check whether the incoming CSN is a carbon copy and show the notification based on that. |
You won't get Carbons for 'groupchat' messages, only for MUC-PMs and for direct messages. |
When I'm in a MUC with full-screen converse (3.3.3), and I start typing, I see "Typing from another device" displayed, despite not being active in any other client at the same time. Is it possible that this was introduced with #802, and that the internal logic sees the MUC reflection as "I'm typing" without checking whether this was initially sent by converse?
Maybe this asks for a complete block of self-typing in MUCs, or at least tracking of our own CSN message IDs so we can ignore them?
The text was updated successfully, but these errors were encountered: