Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal overlays do not have scrollbars #1792

Closed
poVoq opened this issue Nov 23, 2019 · 6 comments
Closed

Modal overlays do not have scrollbars #1792

poVoq opened this issue Nov 23, 2019 · 6 comments
Labels
bug UI User interface
Milestone

Comments

@poVoq
Copy link
Contributor

poVoq commented Nov 23, 2019

Describe the bug
On small screens (with limited vertical resolution) overlay modals like the profile are not usable as it is impossible to reach the "save and close" button at the bottom.

To Reproduce
Steps to reproduce the behavior:

  1. Resize browser window
  2. Click on click on profile overlay modal
  3. Realize that there is no (optional) scrollbar

Environment (please complete the following information):

  • Desktop or Mobile? Both
  • Browser [e.g. Chrome, Firefox] Firefox
  • Converse.js version [e.g. 4.2.0] 5.0.5
@licaon-kter
Copy link
Contributor

Like #1666 ?

@poVoq
Copy link
Contributor Author

poVoq commented Nov 23, 2019

Yeah I think so, just in general.

This seems to work for me if I overwrite the CSS:

#conversejs .modal-body {
    overflow-y: auto;
    height: auto;
    max-height: 600px;
}

@jcbrand jcbrand added this to the 6.0.0 milestone Dec 3, 2019
@jcbrand jcbrand closed this as completed in 5809c97 Dec 3, 2019
@jcbrand
Copy link
Member

jcbrand commented Dec 3, 2019

Should be fixed now, can you please confirm @poVoq?

@jcbrand jcbrand added bug UI User interface labels Dec 3, 2019
@poVoq
Copy link
Contributor Author

poVoq commented Dec 3, 2019

Ahhmm, I actually need to get around getting a working dev setup for ConverseJS :(
Right now I am working with the official releases only and thus can't test it easily.

@jcbrand
Copy link
Member

jcbrand commented Dec 3, 2019

Ahhmm, I actually need to get around getting a working dev setup for ConverseJS

It's really not that hard, as long as you're using Linux or Mac.

Just run make dev and then make watch. Then open http://localhost:8008/dev.html

@licaon-kter
Copy link
Contributor

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI User interface
Projects
None yet
Development

No branches or pull requests

3 participants