-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Create separate repository for Cosmovisor #9994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Cosmovisor is using it's own tags and it's own releases. Moreover Cosmovisor is it's own module. Go works well with installing a binary from a multi module or multi binary repository. I know that it seams more clear to put the Cosmovisor in it's own repository. We had few discussions about it (ps: I was also supporting moving it to other repository) in the past and decided to keep it in the same repository as the Cosmos SDK, because it's managed by the Cosmos SDK team, uses same test flow and hopefully have more awareness about this project. |
Hi Robert, yeah I understand that it is to some extent a matter of personal taste. I see some thumbs-up on the original issue, so I believe other people might hold a similar view as you and I :-) I would still argue that the most appropriate solution is to split the repos as the Cosmos stack is intended to be modular. Already today we have gaia and Cosmos SDK repos separated. The only reason that I spend the time to bring this up was because our validator operations were affected by #9875 and I found the mixing of repos and versioning non-intuitive. If the projects remain glued together it would be a good addition with some installation instructions in the Cosmovisor readme on how to build a specific version. Could be something simple such as |
Thanks for your suggestion @mdyring. Cosmovisor was in a separate repo before and it didn't have enough maintainers. Thus we prefer a mono-repo solution so that we can ensure it gets maintained. If there is a big enough group of maintainers outside the core SDK team at some point, maybe we can re-explore a separate repo then. For now it's staying here. Yes, it is a separate go module with separate version tags and the installation command you suggested is now documented in the README. If there you see other gaps in documentation, please let us know. |
Gaia is a Cosmos SDK chain, not a tool / framework. A week ago (or more) we updated the installation instructions. I hope it's clear now how to install cosmovisor. We are also integrating go releaser to attach binaries to the on GitHub Cosmovisor Release Page. |
Summary
It would be nice for validators to have a single repository for Cosmosvisor with its own tags for versioning and issues tracking specific to Cosmovisor functionality.
Problem Definition
Proposal
For Admin Use
The text was updated successfully, but these errors were encountered: