feat: add isThreadLocal to VariableInfo

Author: sdkrystian

include/mrdox/Metadata/Variable.hpp

@@ -29,6 +29,7 @@ union VariableFlags0
     BitField<0, 3, StorageClassKind> storageClass;
     BitField<3, 2, ConstexprKind> constexprKind;
     BitFlag<5> isConstinit;
+    BitFlag<6> isThreadLocal;
 };
 
 /** A variable.

source/-XML/CXXTags.hpp

@@ -185,6 +185,7 @@ inline void write(VariableFlags0 const& bits, XMLTags& tags)
     fw.write(&VariableFlags0::storageClass, "storage-class");
     fw.write(&VariableFlags0::constexprKind, "constexpr-kind");
     fw.write(&VariableFlags0::isConstinit, "is-constinit");
+    fw.write(&VariableFlags0::isThreadLocal, "is-thread-local");
 }
 
 inline

source/AST/ASTVisitor.cpp

@@ -1364,6 +1364,11 @@ buildVar(
         convertToStorageClassKind(
             D->getStorageClass());
 
+    // this handles thread_local, as well as the C
+    // __thread and __Thread_local specifiers
+    I.specs.isThreadLocal = D->getTSCSpec() !=
+        ThreadStorageClassSpecifier::TSCS_unspecified;
+
     // KRYSTIAN NOTE: VarDecl does not provide getConstexprKind,
     // nor does it use getConstexprKind to store whether
     // a variable is constexpr/constinit. Although

test-files/old-tests/ns-variables.cpp

@@ -14,3 +14,7 @@ double pi = 3.14;
 struct T {};
 
 extern T t;
+
+thread_local int x0 = 0;
+thread_local static int x1 = 0;
+constexpr thread_local static int x2 = 0;

test-files/old-tests/ns-variables.xml

@@ -38,5 +38,23 @@
     <attr id="storage-class" name="extern" value="1"/>
     <type class="tag" id="CgGNdHpW5mG/i5741WPYQDw28OQ=" name="T"/>
   </variable>
+  <variable name="x0" id="LESPWJfwRpePfANf2Vm0O/W1Lfw=">
+    <file path="ns-variables.cpp" line="18" class="def"/>
+    <attr id="is-thread-local"/>
+    <type name="int"/>
+  </variable>
+  <variable name="x1" id="bMKl4XYJf8MQ48jSHwRmFHM3MiA=">
+    <file path="ns-variables.cpp" line="19" class="def"/>
+    <attr id="storage-class" name="static" value="2"/>
+    <attr id="is-thread-local"/>
+    <type name="int"/>
+  </variable>
+  <variable name="x2" id="EpcDWput1W/SJ3IYEINS0W815Zw=">
+    <file path="ns-variables.cpp" line="20" class="def"/>
+    <attr id="storage-class" name="static" value="2"/>
+    <attr id="constexpr-kind" name="constexpr" value="1"/>
+    <attr id="is-thread-local"/>
+    <type name="int" cv-qualifiers="const"/>
+  </variable>
 </namespace>
 </mrdox>

test-files/old-tests/static-data-def.cpp

@@ -12,6 +12,12 @@ struct A
     static constexpr int v7 = 7;
 };
 
+struct B
+{
+    static thread_local const int x0 = 0;
+    static constexpr thread_local int x1 = 0;
+};
+
 template<typename T>
 int A<T>::v0 = 0;
 
@@ -39,3 +45,5 @@ auto f()
         A<int>::v6 +
         A<int>::v7;
 }
+
+thread_local const int B::x0;

test-files/old-tests/static-data-def.xml

@@ -7,32 +7,32 @@
     <struct name="A" id="5tUSuMtQqtYE49jBjSYSWp0DJAM=">
       <file path="static-data-def.cpp" line="2" class="def"/>
       <variable name="v0" id="rW6h+mCfZLROHlYzwXFIUPN6oSE=">
-        <file path="static-data-def.cpp" line="15" class="def"/>
+        <file path="static-data-def.cpp" line="21" class="def"/>
         <file path="static-data-def.cpp" line="4"/>
         <attr id="storage-class" name="static" value="2"/>
         <type name="int"/>
       </variable>
       <variable name="v1" id="nkB0lMmDvMsu9GDrKr3Mzwi5g6I=">
-        <file path="static-data-def.cpp" line="18" class="def"/>
+        <file path="static-data-def.cpp" line="24" class="def"/>
         <file path="static-data-def.cpp" line="5"/>
         <attr id="storage-class" name="static" value="2"/>
         <type name="int"/>
       </variable>
       <variable name="v2" id="e48c97dC3AIWJHWE5T0yWVxezgg=">
-        <file path="static-data-def.cpp" line="21" class="def"/>
+        <file path="static-data-def.cpp" line="27" class="def"/>
         <file path="static-data-def.cpp" line="6"/>
         <attr id="storage-class" name="static" value="2"/>
         <attr id="constexpr-kind" name="constexpr" value="1"/>
         <type name="int" cv-qualifiers="const"/>
       </variable>
       <variable name="v3" id="Wx5S5oWv5o4nV7I+zFEKTvWl40g=">
-        <file path="static-data-def.cpp" line="24" class="def"/>
+        <file path="static-data-def.cpp" line="30" class="def"/>
         <file path="static-data-def.cpp" line="7"/>
         <attr id="storage-class" name="static" value="2"/>
         <type name="int" cv-qualifiers="const"/>
       </variable>
       <variable name="v4" id="6a2wBN4mHiuAAqV0gYgYQeqFNVM=">
-        <file path="static-data-def.cpp" line="27" class="def"/>
+        <file path="static-data-def.cpp" line="33" class="def"/>
         <file path="static-data-def.cpp" line="8"/>
         <attr id="storage-class" name="static" value="2"/>
         <type name="int" cv-qualifiers="const"/>
@@ -55,8 +55,25 @@
       </variable>
     </struct>
   </template>
+  <struct name="B" id="3JsK1DO0O+wZhv+0meptQrbs3fY=">
+    <file path="static-data-def.cpp" line="15" class="def"/>
+    <variable name="x0" id="+yhNlGuTVY4spCfBXSTBkEDzi30=">
+      <file path="static-data-def.cpp" line="49" class="def"/>
+      <file path="static-data-def.cpp" line="17"/>
+      <attr id="storage-class" name="static" value="2"/>
+      <attr id="is-thread-local"/>
+      <type name="int" cv-qualifiers="const"/>
+    </variable>
+    <variable name="x1" id="vNYWHh2ovZiBP3uVEeJhMkaiF3w=">
+      <file path="static-data-def.cpp" line="18" class="def"/>
+      <attr id="storage-class" name="static" value="2"/>
+      <attr id="constexpr-kind" name="constexpr" value="1"/>
+      <attr id="is-thread-local"/>
+      <type name="int" cv-qualifiers="const"/>
+    </variable>
+  </struct>
   <function name="f" id="s6nsa+zVhpzzrN+yUVPP5rvdXqs=">
-    <file path="static-data-def.cpp" line="30" class="def"/>
+    <file path="static-data-def.cpp" line="36" class="def"/>
     <return>
       <type name="int"/>
     </return>