fix: compilation with BUILD_SHARED_LIBS with MSVC

Author: Nerixyz

.github/workflows/ci.yml

@@ -40,7 +40,7 @@ jobs:
             apple-clang *
           standards: '20'
           latest-factors: |
-            msvc Optimized-Debug
+            msvc Optimized-Debug Shared
             gcc Coverage
           factors: ''
           runs-on: |
@@ -375,6 +375,7 @@ jobs:
           package-dir: packages
           package-generators: ${{ matrix.mrdocs-package-generators }}
           package-artifact: false
+          shared: ${{ matrix.shared }}
 
       - name: Check YAML schema
         run: |

CMakeLists.txt

@@ -292,11 +292,11 @@ if (WIN32)
         target_compile_options(
             mrdocs-core
             PUBLIC
-            /permissive-    # strict C++
-            /W4             # enable all warnings
-            /MP             # multi-processor compilation
-            /EHs            # C++ Exception handling
-            $<$<CONFIG:Debug>:/Oy-> # Disable frame pointer omission
+            /permissive-                    # strict C++
+            /W4                             # enable all warnings
+            $<$<CXX_COMPILER_ID:MSVC>:/MP>  # multi-processor compilation
+            /EHs                            # C++ Exception handling
+            $<$<CONFIG:Debug>:/Oy->         # Disable frame pointer omission
         )
     endif()
 endif ()
@@ -326,7 +326,6 @@ list(APPEND TOOL_SOURCES
         ${CMAKE_CURRENT_BINARY_DIR}/src/tool/PublicToolArgs.cpp)
 
 add_executable(mrdocs ${TOOL_SOURCES})
-target_compile_definitions(mrdocs PRIVATE -DMRDOCS_TOOL)
 
 target_include_directories(mrdocs
     PUBLIC
@@ -338,7 +337,6 @@ target_include_directories(mrdocs
     "${PROJECT_BINARY_DIR}/src"
 )
 
-target_compile_definitions(mrdocs PRIVATE -DMRDOCS_TOOL)
 target_link_libraries(mrdocs PUBLIC mrdocs-core)
 if (MRDOCS_CLANG)
     target_compile_options(

include/mrdocs/Config.hpp

@@ -60,7 +60,7 @@ class MRDOCS_DECL
 public:
     /** Settings values used to generate the Corpus and Docs
      */
-    struct Settings : public PublicSettings
+    struct MRDOCS_DECL Settings : public PublicSettings
     {
         /**
          * @brief Loads the public configuration settings from the specified YAML file.
@@ -157,13 +157,11 @@ class MRDOCS_DECL
 
     /** Destructor.
     */
-    MRDOCS_DECL
     virtual
     ~Config() noexcept = 0;
 
     /** Return a pool of threads for executing work.
     */
-    MRDOCS_DECL
     virtual
     ThreadPool&
     threadPool() const noexcept = 0;

include/mrdocs/Dom/Array.hpp

@@ -269,18 +269,21 @@ class MRDOCS_DECL
     /** Compare two arrays for equality.
      */
     friend
+    MRDOCS_DECL
     bool
     operator==(Array const&, Array const&) noexcept;
 
     /** Compare two arrays for precedence.
      */
     friend
+    MRDOCS_DECL
     std::strong_ordering
     operator<=>(Array const&, Array const&) noexcept;
 
     /** Return a diagnostic string.
     */
     friend
+    MRDOCS_DECL
     std::string
     toString(Array const&);
 
@@ -364,6 +367,13 @@ class MRDOCS_DECL
     DefaultArrayImpl();
     explicit DefaultArrayImpl(
         storage_type elements) noexcept;
+
+    DefaultArrayImpl(const DefaultArrayImpl&);
+    DefaultArrayImpl(DefaultArrayImpl&&);
+    DefaultArrayImpl& operator=(const DefaultArrayImpl&);
+    DefaultArrayImpl& operator=(DefaultArrayImpl&&);
+    ~DefaultArrayImpl();
+    
     size_type size() const override;
     value_type get(size_type i) const override;
     void set(size_type i, Value v) override;

include/mrdocs/Dom/Object.hpp

@@ -298,6 +298,7 @@ class MRDOCS_DECL
     /** Compare two objects for equality.
      */
     friend
+    MRDOCS_DECL
     bool
     operator==(Object const& a, Object const& b) noexcept;
 
@@ -318,7 +319,7 @@ class MRDOCS_DECL
 
     /** Return a diagnostic string.
     */
-    friend std::string toString(Object const&);
+    friend MRDOCS_DECL std::string toString(Object const&);
 };
 
 //------------------------------------------------
@@ -402,6 +403,11 @@ class MRDOCS_DECL
 {
 public:
     DefaultObjectImpl() noexcept;
+    DefaultObjectImpl(const DefaultObjectImpl&);
+    DefaultObjectImpl(DefaultObjectImpl&&);
+    DefaultObjectImpl& operator=(const DefaultObjectImpl&);
+    DefaultObjectImpl& operator=(DefaultObjectImpl&&);
+    ~DefaultObjectImpl();
 
     explicit DefaultObjectImpl(
         storage_type entries) noexcept;

include/mrdocs/Dom/Value.hpp

@@ -46,9 +46,11 @@ namespace mrdocs {
 
     @see https://handlebarsjs.com/api-reference/utilities.html#handlebars-safestring-string
  */
+MRDOCS_DECL
 dom::Value
 safeString(std::string_view str);
 
+MRDOCS_DECL
 dom::Value
 safeString(dom::Value const& str);
 
@@ -415,6 +417,7 @@ class MRDOCS_DECL
         operator, which does not perform type conversions.
      */
     friend
+    MRDOCS_DECL
     bool
     operator==(
         Value const& lhs,
@@ -423,6 +426,7 @@ class MRDOCS_DECL
     /** Compare two values for inequality.
      */
     friend
+    MRDOCS_DECL
     std::strong_ordering
     operator<=>(
         Value const& lhs,
@@ -453,6 +457,7 @@ class MRDOCS_DECL
     /** Add or concatenate two values.
      */
     friend
+    MRDOCS_DECL
     dom::Value
     operator+(Value const& lhs, Value const& rhs);
 
@@ -477,6 +482,7 @@ class MRDOCS_DECL
         This function is equivalent to the JavaScript `||` operator.
      */
     friend
+    MRDOCS_DECL
     dom::Value
     operator||(Value const& lhs, Value const& rhs);
 
@@ -501,6 +507,7 @@ class MRDOCS_DECL
         This function is equivalent to the JavaScript `&&` operator.
      */
     friend
+    MRDOCS_DECL
     dom::Value
     operator&&(Value const& lhs, Value const& rhs);
 
@@ -523,6 +530,7 @@ class MRDOCS_DECL
     /** Return value as a string.
     */
     friend
+    MRDOCS_DECL
     std::string
     toString(Value const& value);
 };

include/mrdocs/Metadata/Javadoc.hpp

@@ -371,6 +371,12 @@ struct Copied : Reference
 struct MRDOCS_DECL
     Block : Node
 {
+    Block(const Block&) = delete;
+    Block(Block&&);
+    Block& operator=(const Block&) = delete;
+    Block& operator=(Block&&);
+    ~Block();
+
     List<Text> children;
 
     bool isBlock() const noexcept final
@@ -919,7 +925,6 @@ class MRDOCS_DECL
 public:
     /** Constructor.
     */
-    MRDOCS_DECL
     Javadoc() noexcept;
 
     /** Constructor
@@ -928,6 +933,11 @@ class MRDOCS_DECL
     Javadoc(
         doc::List<doc::Block> blocks);
 
+    Javadoc(const Javadoc&) = delete;
+    Javadoc(Javadoc&&);
+    Javadoc& operator=(const Javadoc&) = delete;
+    Javadoc& operator=(Javadoc&&);
+
     /** Return true if this is empty
     */
     bool

include/mrdocs/Platform.hpp

@@ -11,7 +11,6 @@
 #ifndef MRDOCS_API_PLATFORM_HPP
 #define MRDOCS_API_PLATFORM_HPP
 
-#include <mrdocs/Support/Assert.hpp>
 #include <type_traits>
 
 #if __cplusplus < 202002L
@@ -79,4 +78,6 @@ namespace mrdocs {
 } // mrdocs
 } // clang
 
+#include <mrdocs/Support/Assert.hpp>
+
 #endif

include/mrdocs/Support/Assert.hpp

@@ -11,6 +11,7 @@
 #ifndef MRDOCS_API_SUPPORT_ASSERT_HPP
 #define MRDOCS_API_SUPPORT_ASSERT_HPP
 
+#include <mrdocs/Platform.hpp>
 #include <cstdint>
 
 namespace clang {
@@ -30,6 +31,7 @@ namespace mrdocs {
         #define MRDOCS_UNREACHABLE() static_cast<void>(__debugbreak(), __assume(false))
     #endif
 
+    MRDOCS_DECL
     void
     assert_failed(
         const char* msg,

include/mrdocs/Support/Glob.hpp

@@ -31,7 +31,7 @@ namespace clang::mrdocs {
 
     Nested brace expansions "{<glob>,"{<glob>,...}",...}" are not supported.
  */
-class GlobPattern {
+class MRDOCS_DECL GlobPattern {
     struct Impl;
     std::unique_ptr<Impl> impl_;
 public:
@@ -110,7 +110,7 @@ class GlobPattern {
     A glob pattern matcher where "*" does not match path separators.
     The pattern "**" can be used to match any number of path separators.
  */
-class PathGlobPattern {
+class MRDOCS_DECL PathGlobPattern {
     GlobPattern glob_;
 public:
     /** Constructs a PathGlobPattern with the given pattern.
@@ -201,7 +201,7 @@ class PathGlobPattern {
     A glob pattern matcher where "*" does not match "::".
     The pattern "**" can be used to match any number of "::".
  */
-class SymbolGlobPattern {
+class MRDOCS_DECL SymbolGlobPattern {
     GlobPattern glob_;
 public:
     /** Constructs a SymbolGlobPattern with the given pattern.

include/mrdocs/Support/Handlebars.hpp

@@ -633,7 +633,7 @@ namespace detail {
 
     @see https://handlebarsjs.com/
  */
-class Handlebars {
+class MRDOCS_DECL Handlebars {
     using helpers_map = std::unordered_map<
         std::string, dom::Function, detail::string_hash, std::equal_to<>>;