cleanup

Author: sdkrystian

include/mrdox/Corpus.hpp

@@ -103,8 +103,6 @@ class MRDOX_VISIBLE
         MRDOX_DECL virtual bool visit(TypedefInfo const&);
         MRDOX_DECL virtual bool visit(EnumInfo const&);
         MRDOX_DECL virtual bool visit(VarInfo const&);
-        // KRYSTIAN FIXME: is this correct? does it make sense to
-        // visit a field as a non-member (a field *must* be class member)?
         MRDOX_DECL virtual bool visit(FieldInfo const&);
         MRDOX_DECL virtual bool visit(SpecializationInfo const&);
 

include/mrdox/Metadata/Record.hpp

@@ -118,10 +118,7 @@ enum class RecordKeyKind
 {
     Struct,
     Class,
-    Union,
-    // KRYSTIAN NOTE: __interface is a Microsoft extension,
-    // do we want to support it?
-    Interface
+    Union
 };
 
 /** Metadata for struct, class, or union.

source/-XML/CXXTags.cpp

@@ -29,7 +29,6 @@ getTagName(Info const& I) noexcept
         case RecordKeyKind::Class:     return classTagName;
         case RecordKeyKind::Struct:    return structTagName;
         case RecordKeyKind::Union:     return unionTagName;
-        case RecordKeyKind::Interface: return interfaceTagName;
         default:
             break;
         }

source/-XML/CXXTags.hpp

@@ -41,7 +41,6 @@ constexpr llvm::StringRef javadocTagName        = "doc";
 constexpr llvm::StringRef enumTagName           = "enum";
 constexpr llvm::StringRef friendTagName         = "friend";
 constexpr llvm::StringRef functionTagName       = "function";
-constexpr llvm::StringRef interfaceTagName      = "interface";
 constexpr llvm::StringRef namespaceTagName      = "namespace";
 constexpr llvm::StringRef paramTagName          = "param";
 constexpr llvm::StringRef returnTagName         = "return";

source/-XML/XMLWriter.cpp

@@ -384,7 +384,6 @@ writeRecord(
     case RecordKeyKind::Class:     tagName = classTagName; break;
     case RecordKeyKind::Struct:    tagName = structTagName; break;
     case RecordKeyKind::Union:     tagName = unionTagName; break;
-    case RecordKeyKind::Interface: tagName = interfaceTagName; break;
     default:
         Assert(false);
     }

source/-adoc/AdocWriter.cpp

@@ -852,7 +852,6 @@ recordKeyToString(RecordKeyKind k) noexcept
     switch(k)
     {
     case RecordKeyKind::Struct: return "struct";
-    case RecordKeyKind::Interface: return "__interface";
     case RecordKeyKind::Union: return "union";
     case RecordKeyKind::Class: return "class";
     default:

source/AST/ASTVisitor.cpp

@@ -773,11 +773,6 @@ buildRecord(
     case TagTypeKind::TTK_Union:
         I.KeyKind = RecordKeyKind::Union;
         break;
-    // KRYSTIAN NOTE: do want to support __interface?
-    // it is a Microsoft extension.
-    case TagTypeKind::TTK_Interface:
-        I.KeyKind = RecordKeyKind::Interface;
-        break;
     default:
         llvm_unreachable("unsupported TagTypeKind");
     }

source/AST/BitcodeWriter.cpp

@@ -140,21 +140,6 @@ static void MemberRefsAbbrev(
             llvm::BitCodeAbbrevOp::Fixed, 8) });
 }
 
-#if 0
-static void SpecializedMemAbbrev(
-    std::shared_ptr<llvm::BitCodeAbbrev>& Abbrev)
-{
-    AbbrevGen(Abbrev, {
-        // 0. Fixed-size array of 21-byte SymbolID pairs
-        llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::Array),
-        llvm::BitCodeAbbrevOp(
-            llvm::BitCodeAbbrevOp::Fixed, 8),
-        llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::Array),
-        llvm::BitCodeAbbrevOp(
-            llvm::BitCodeAbbrevOp::Fixed, 8) });
-}
-#endif
-
 static void StringAbbrev(
     std::shared_ptr<llvm::BitCodeAbbrev>& Abbrev)
 {

source/AST/DecodeRecord.hpp

@@ -129,37 +129,6 @@ decodeRecord(
     return Error::success();
 }
 
-#if 0
-// vector<SpecializedMember>
-inline
-Error
-decodeRecord(
-    Record const& R,
-    std::vector<SpecializedMember>& f,
-    llvm::StringRef blob)
-{
-    constexpr auto SpecializedMemberSize =
-        BitCodeConstants::USRHashSize * 2;
-    if(R.empty())
-        return Error("record is empty");
-    auto n = R.size() / SpecializedMemberSize;
-    if(R.size() != n * SpecializedMemberSize)
-        return Error("record is short");
-    auto src = R.begin();
-    f.resize(n);
-    auto* dest = &f[0];
-    while(n--)
-    {
-        dest->Primary = SymbolID(src);
-        src += BitCodeConstants::USRHashSize;
-        dest->Specialized = SymbolID(src);
-        src += BitCodeConstants::USRHashSize;
-        ++dest;
-    }
-    return Error::success();
-}
-#endif
-
 inline
 Error
 decodeRecord(

source/Metadata/Info.cpp

@@ -107,8 +107,6 @@ symbolType() const noexcept
             return "class";
         case RecordKeyKind::Union:
             return "union";
-        case RecordKeyKind::Interface:
-            return "interface";
         default:
             llvm_unreachable("unknown RecordKeyKind");
         }