Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension request: intl on Windows #435

Closed
Tracked by #152
simonhamp opened this issue May 3, 2024 · 4 comments
Closed
Tracked by #152

Extension request: intl on Windows #435

simonhamp opened this issue May 3, 2024 · 4 comments
Labels
kind/extension Issues related to extensions new feature New feature or request os/windows Things only for Windows

Comments

@simonhamp
Copy link
Contributor

Slightly more urgent than #429

I am going to dig into how to do it, but just wanted to raise the ticket.

@crazywhalecc crazywhalecc added new feature New feature or request kind/extension Issues related to extensions os/windows Things only for Windows labels May 4, 2024
@crazywhalecc
Copy link
Owner

I tried to add intl/icu support on Windows. The icu library seems to have some trouble with producing pure static libs under MSVC: The official vcxproj file only provides options to build dll.

https://github.com/unicode-org/icu/blob/69cb085e12764b84269c31be5a054e7c510be443/icu4c/source/i18n/i18n.vcxproj#L68C1-L79C25

I may need to first solve the problem of existing extensions not being able to compile before I can actually deal with it.

@crazywhalecc
Copy link
Owner

Closed: #445 (comment)

@crazywhalecc crazywhalecc closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
@simonhamp
Copy link
Contributor Author

Can we revisit this yet?

@ramsey
Copy link

ramsey commented Jan 16, 2025

There's an interesting note here about --enable-static under "Configuring ICU on Windows": https://unicode-org.github.io/icu/userguide/icu4c/build.html#configuring-icu-on-windows

the following configure options currently do not work on Windows with Microsoft’s compiler. Some options can work by manually editing icu/source/common/unicode/pwin32.h, but manually editing the files is not recommended.

[...]

  • --enable-static (Requires that U_STATIC_IMPLEMENTATION be defined in user code that links against ICU’s static libraries.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/extension Issues related to extensions new feature New feature or request os/windows Things only for Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants