Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg #668

Open
DubbleClick opened this issue Mar 20, 2025 · 4 comments
Open

vcpkg #668

DubbleClick opened this issue Mar 20, 2025 · 4 comments
Labels
question Further information is requested

Comments

@DubbleClick
Copy link
Collaborator

I've switched most of my hobby projects over from pure cmake to cmake with the vcpkg integration. So far it has been a breeze.

I've had a look at it seems like most of our libraries could be built by vcpkg. This could potentially not only save us a lot of maintenance (vcpkg is very successful at guaranteeing build success) but also configuration.

This will take some research with linking against different libc/libc++'s though. Not a priority.

@DubbleClick DubbleClick added the question Further information is requested label Mar 20, 2025
@DubbleClick
Copy link
Collaborator Author

https://github.com/gwdevhub/GWToolboxpp/pull/1257/files

Take a look at the amount of cmake configuration that just evaporated. Total vcpkg configuration is like 40 lines of code, 20 of which come from using a shared-library discord sdk in an otherwise static build.

@crazywhalecc
Copy link
Owner

crazywhalecc commented Mar 23, 2025

It does look like a good approach. But it is different from our downloads and doctor at the moment, at least we separate downloading and building, and also this may require a huge PR or gradually replace the supporting libraries.

However, this is not our priority work, given that there are other issues to solve now. But I think windows should be a good start of this, because the default build components of many libraries on Windows do not support parallel builds. Also, I found vcpkg supports icu build, may be a good solution for #445 .

@DubbleClick
Copy link
Collaborator Author

I think vcpkg generally supports almost everything we need. The only thing I'm somewhat unsure about is its support to compile against different libc's.

@DubbleClick
Copy link
Collaborator Author

It supports it by specifying a cmake toolchain file to the triplet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants