Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml msrv appears to be incorrect #807

Open
eric-seppanen opened this issue Feb 25, 2025 · 0 comments
Open

Cargo.toml msrv appears to be incorrect #807

eric-seppanen opened this issue Feb 25, 2025 · 0 comments

Comments

@eric-seppanen
Copy link

clippy reports msrv problems:

cargo-crev$ cargo clippy --all-features --all-targets -- -Aclippy::all -Wclippy::incompatible_msrv
    Checking crev-common v0.26.3 (.../cargo-crev/crev-common)
    Checking crev-data v0.26.3 (.../cargo-crev/crev-data)
    Checking crev-wot v0.26.3 (.../cargo-crev/crev-wot)
    Checking crev-lib v0.26.3 (.../cargo-crev/crev-lib)
warning: current MSRV (Minimum Supported Rust Version) is `1.77.0` but this item is stable since `1.79.0`
   --> crev-lib/src/util/mod.rs:226:21
    |
226 |     for ch in input.utf8_chunks() {
    |                     ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
    = note: requested on the command line with `-W clippy::incompatible-msrv`

warning: current MSRV (Minimum Supported Rust Version) is `1.77.0` but this item is stable since `1.79.0`
   --> crev-lib/src/util/mod.rs:227:63
    |
227 |         output.extend_from_slice(escape_tricky_unicode_str(ch.valid()).as_bytes());
    |                                                               ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv

warning: current MSRV (Minimum Supported Rust Version) is `1.77.0` but this item is stable since `1.79.0`
   --> crev-lib/src/util/mod.rs:228:37
    |
228 |         output.extend_from_slice(ch.invalid());
    |                                     ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv

warning: `crev-lib` (lib) generated 3 warnings
    Checking cargo-crev v0.26.3 (.../cargo-crev/cargo-crev)
warning: `crev-lib` (lib test) generated 3 warnings (3 duplicates)
warning: current MSRV (Minimum Supported Rust Version) is `1.77.0` but this item is stable since `1.82.0`
   --> cargo-crev/src/shared.rs:637:39
    |
637 |                 if args.diff.as_ref().is_none_or(|new_base| new_base == &latest.diff_base) {
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
    = note: requested on the command line with `-W clippy::incompatible-msrv`

warning: `cargo-crev` (bin "cargo-crev") generated 1 warning
warning: `cargo-crev` (bin "cargo-crev" test) generated 1 warning (1 duplicate)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.94s

Additionally, cargo-msrv reports that the cargo 0.85.0 dependency requires rust 1.82.0. In another PR I bumped it to 0.86.0 which requires rust 1.83.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant