more permissive check for json to include application/vnd.api+j… (#5166)

* more permissive check for json to include

* add json test for content-type application/vnd.api+json

* cruder solution passes e2e tests locally, so let's go with that

* Remove 'charset' from content-type before checking if JSON

Author: jazwiecki

packages/server/lib/request.coffee

@@ -381,7 +381,8 @@ module.exports = (options = {}) ->
 
     contentTypeIsJson: (response) ->
       ## TODO: use https://github.com/jshttp/type-is for this
-      response?.headers?["content-type"]?.includes("application/json")
+      ## https://github.com/cypress-io/cypress/pull/5166
+      response?.headers?["content-type"]?.split(';', 2)[0].endsWith("json")
 
     parseJsonBody: (body) ->
       try

packages/server/test/unit/request_spec.coffee

@@ -435,6 +435,20 @@ describe "lib/request", ->
       .then (resp) ->
         expect(resp.body).to.deep.eq({status: "ok"})
 
+    it "parses response body as json if content-type application/vnd.api+json response headers", ->
+      nock("http://localhost:8080")
+      .get("/status.json")
+      .reply(200, JSON.stringify({status: "ok"}), {
+        "Content-Type": "application/vnd.api+json"
+      })
+
+      request.sendPromise({}, @fn, {
+        url: "http://localhost:8080/status.json"
+        cookies: false
+      })
+      .then (resp) ->
+        expect(resp.body).to.deep.eq({status: "ok"})
+
     it "revives from parsing bad json", ->
       nock("http://localhost:8080")
       .get("/status.json")