You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+7-7
Original file line number
Diff line number
Diff line change
@@ -13,20 +13,20 @@ The core team works directly on GitHub and all work is public.
13
13
> **Working on your first pull request?** You can learn how from this *free* series: [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github).
14
14
15
15
1. Fork the repo and create your branch from `master` (a guide on [how to fork a repository](https://help.github.com/articles/fork-a-repo/)).
16
-
2. Run `yarn bootstrap` to setup the developement environment.
16
+
2. Run `yarn bootstrap` to setup the development environment.
17
17
3. Do the changes you want and test them out in the example app before sending a pull request.
18
18
19
19
### Commit message convention
20
20
21
-
We prefix our commit messages with one of the following to signify the kind of change:
21
+
We follow the [conventional commits specification](https://www.conventionalcommits.org/en) for our commit messages:
22
22
23
23
*`fix`: bug fixes, e.g. fix Button color on DarkTheme.
24
24
*`feat`: new features, e.g. add Snackbar component.
25
-
*`refactor`: code/structure refactor, e.g. new structure folder for components.
25
+
*`refactor`: code refactor, e.g. new folder structure for components.
26
26
*`docs`: changes into documentation, e.g. add usage example for Button.
27
27
*`test`: adding or updating tests, eg unit, snapshot testing.
28
28
*`chore`: tooling changes, e.g. change circleci config.
29
-
*`BREAKING`: for changes that break existing usage, e.g. change API of a component.
29
+
*`BREAKING CHANGE`: for changes that break existing usage, e.g. change API of a component.
30
30
31
31
Our pre-commit hooks verify that your commit message matches this format when committing.
32
32
@@ -35,9 +35,9 @@ Our pre-commit hooks verify that your commit message matches this format when co
35
35
We use `flow` for type checking, `eslint` with `prettier` for linting and formatting the code, and `jest` for testing. Our pre-commit hooks verify that the linter and tests pass when commiting. You can also run the following commands manually:
36
36
37
37
*`yarn flow`: run flow on all files.
38
-
*`yarn typescript`: run tests for typescript.
39
-
*`yarn lint`: run eslint and prettier.
40
-
*`yarn test`: run unit tests.
38
+
*`yarn typescript`: run tests for typescript definitions.
39
+
*`yarn lint`: lint files with eslint and prettier.
0 commit comments