Skip to content

Commit 6f6ba3e

Browse files
committed
fixup: use isDetachedBuffer only
Signed-off-by: Daeyeon Jeong [email protected]
1 parent 50c7728 commit 6f6ba3e

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

lib/internal/webstreams/readablestream.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ const {
102102
extractSizeAlgorithm,
103103
lazyTransfer,
104104
isDetachedBuffer,
105-
isViewedArrayBufferDetached,
106105
isBrandCheck,
107106
resetQueue,
108107
setPromiseHandled,
@@ -684,7 +683,7 @@ class ReadableStreamBYOBRequest {
684683
'This BYOB request has been invalidated');
685684
}
686685

687-
if (isViewedArrayBufferDetached(view)) {
686+
if (isDetachedBuffer(ArrayBufferViewGetBuffer(view))) {
688687
throw new ERR_INVALID_STATE.TypeError('Viewed ArrayBuffer is detached');
689688
}
690689

lib/internal/webstreams/util.js

+4-14
Original file line numberDiff line numberDiff line change
@@ -130,23 +130,14 @@ function transferArrayBuffer(buffer) {
130130
}
131131

132132
function isDetachedBuffer(buffer) {
133-
if (ArrayBufferGetByteLength(buffer) === 0) {
134-
try {
135-
new Uint8Array(buffer);
136-
} catch {
137-
return true;
138-
}
133+
try {
134+
new Uint8Array(buffer);
135+
} catch {
136+
return true;
139137
}
140138
return false;
141139
}
142140

143-
function isViewedArrayBufferDetached(view) {
144-
return (
145-
ArrayBufferViewGetByteLength(view) === 0 &&
146-
isDetachedBuffer(ArrayBufferViewGetBuffer(view))
147-
);
148-
}
149-
150141
function dequeueValue(controller) {
151142
assert(controller[kState].queue !== undefined);
152143
assert(controller[kState].queueTotalSize !== undefined);
@@ -245,7 +236,6 @@ module.exports = {
245236
isBrandCheck,
246237
isDetachedBuffer,
247238
isPromisePending,
248-
isViewedArrayBufferDetached,
249239
peekQueueValue,
250240
resetQueue,
251241
setPromiseHandled,

0 commit comments

Comments
 (0)