-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cross-platform float-point values inconsistency #12515
Comments
Perhaps I can take charge of improving this part? |
PR is always welcome |
FYI: You could use x87 floating point instructions to enforce consistent behavior across all platforms. I haven't delved deeply into this, but you might want to investigate if you're interested. But I'm not sure Apple's chips respect this instruction set. And though some compilers like GCC supports x87, its manual says:
|
Get. Thank you for your suggestion. |
I have done some research on this matter and found that there are multiple possible causes for this issue. You can refer to this link: rust-lang/rust#114479 (comment) for more details. It seems that achieving complete consistency in floating-point precision across all platforms is not entirely feasible. Perhaps it would be more practical to focus on modifying the test cases for now? |
Agreed, the main target is to make test cases pass. |
I understand this, but it may cause unit tests to fail on the macOS platform. Therefore, it might be necessary to modify the test cases or optimize this part to address the issue?
Originally posted by @ct20000901 in #12510 (comment)
The text was updated successfully, but these errors were encountered: