Fix base tests; Add test stub for foreign key constraint in createTable;

Author: kremio

test/foreign_key_batch.js

@@ -0,0 +1,68 @@
+const dbmeta = require('db-meta')
+const dataType = require('db-migrate-shared').dataType
+const fs = require('fs')
+
+module.exports = (driver, config, internals) => ({
+  'columnForeignKeySpec': {
+    topic: function () {
+      driver.connect(config, internals, function (err, db) {
+        db.createTable('event_type', {
+
+          id: { type: dataType.INTEGER, primaryKey: true, autoIncrement: true },
+          title: { type: dataType.STRING }
+        }, function(err) {
+          if (err) {
+              return this.callback(err);
+            }
+          db.createTable('event', {
+            id: {
+              type: dataType.INTEGER,
+              primaryKey: true,
+              autoIncrement: true
+            },
+            event_id: {
+              type: dataType.INTEGER,
+              notNull: true,
+              foreignKey: {
+                name: 'fk_event_event_type',
+                table: 'event_type',
+                mapping: 'id',
+                rules: {
+                  onDelete: 'CASCADE'
+                },
+              } },
+            title: {
+              type: dataType.STRING
+            }
+          }, this.callback.bind(this, null, db));
+        }.bind(this));
+      }.bind(this))
+     },
+
+    teardown: function(db) {
+        db.close(function (err) {
+          fs.unlink(config.filename, this.callback);
+        }.bind(this));
+    },
+
+    'sets usage and constraints': {
+      topic: function (db) {
+        dbmeta('sqlite3', {connection: db.connection}, function (err, meta) {
+          if (err) {
+            return this.callback(err);
+          }
+          meta.getColumns('event', this.callback);
+        }.bind(this));
+      },
+      'that has foreign key column with the expected reference': function (err, columns) {
+        console.log(err, columns)
+        /*var column = findByName(columns, 'id');
+        assert.equal(column.getDataType(), 'INTEGER');
+        assert.equal(column.isPrimaryKey(), true);
+        assert.equal(column.isNullable(), false);
+        assert.equal(column.isAutoIncrementing(), true);*/
+      }
+
+    }
+  }
+})

test/sqlite3_test.js

@@ -8,6 +8,8 @@ var driver = require('../');
 
 var config = require('./db.config.json').sqlite3;
 
+var foreignKeyBatch = require('./foreign_key_batch')
+
 var internals = {};
 internals.mod = {
   log: log,
@@ -22,7 +24,9 @@ internals.migrationTable = 'migrations';
 vows.describe('sqlite3').addBatch({
   'createTable': {
     topic: function () {
+      console.log("cc")
       driver.connect(config, internals, function (err, db) {
+        console.log("cc_cc")
         db.createTable('event', {
           id: { type: dataType.INTEGER, primaryKey: true, autoIncrement: true, notNull: true },
           str: { type: dataType.STRING, unique: true },
@@ -36,9 +40,10 @@ vows.describe('sqlite3').addBatch({
     },
 
     teardown: function (db) {
+      console.log('tt')
       db.close(function (err) {
         fs.unlink(config.filename, this.callback);
-      });
+      }.bind(this));
     },
 
     'has resulting table metadata': {
@@ -138,7 +143,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has table metadata': {
@@ -172,7 +177,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has table metadata': {
@@ -208,7 +213,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has column metadata': {
@@ -249,7 +254,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has resulting index metadata': {
@@ -287,7 +292,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'with additional row': function (db) {
@@ -312,7 +317,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'with additional row': function (db) {
@@ -339,7 +344,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has resulting index metadata': {
@@ -376,7 +381,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has resulting index metadata': {
@@ -406,7 +411,7 @@ vows.describe('sqlite3').addBatch({
       teardown: function (db) {
         db.close(function (err) {
           fs.unlink(config.filename, this.callback);
-        });
+        }.bind(this));
       },
 
       'has migrations table': {
@@ -452,7 +457,8 @@ vows.describe('sqlite3').addBatch({
         }
       }
     }
-  }).export(module);
+}).addBatch( foreignKeyBatch(driver, config, internals) )
+  .export(module);
 
 function findByName(columns, name) {
   for (var i = 0; i < columns.length; i++) {