workaround flag for #949

Author: gordonwoodhull

Changelog.md

@@ -1,4 +1,7 @@
 # 2.0 Series
+## 2.0.4
+* Temporary flag [`stackMixin.evadeDomainFilter`](http://dc-js.github.io/dc.js/docs/html/dc.stackMixin.html#evadeDomainFilter__anchor) to work around [issue #949](https://github.com/dc-js/dc.js/issues/949) until it's fixed. The flag completely disables filtering of points by the stack mixin, because the current filtering is wrong. (The correct fix will be included in dc.js 2.1.x when it's ready.)
+
 ## 2.0.3
 * crossfilter is loaded by its module name (crossfilter2), not its filename (crossfilter). This is intended to help webpack and other automatic module loaders. This is likely to break requireJS configurations; see [#1304](https://github.com/dc-js/dc.js/issues/1304) for details. ([#1213](https://github.com/dc-js/dc.js/issues/1213), [#1214](https://github.com/dc-js/dc.js/issues/1214), [#1261](https://github.com/dc-js/dc.js/issues/1261), [#1293](https://github.com/dc-js/dc.js/issues/1293), [#1302](https://github.com/dc-js/dc.js/issues/1302))
 * Do not make the pie chart radius bigger than the chart size, by Sandeep Fatangare ([#1279](https://github.com/dc-js/dc.js/pull/1279))

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dc",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "license": "Apache-2.0",
   "copyright": "2017",
   "description": "A multi-dimensional charting library built to work natively with crossfilter and rendered using d3.js ",

src/stack-mixin.js

@@ -32,9 +32,10 @@ dc.stackMixin = function (_chart) {
     var _titles = {};
 
     var _hidableStacks = false;
+    var _evadeDomainFilter = false;
 
     function domainFilter () {
-        if (!_chart.x()) {
+        if (!_chart.x() || _evadeDomainFilter) {
             return d3.functor(true);
         }
         var xDomain = _chart.x().domain();
@@ -263,6 +264,30 @@ dc.stackMixin = function (_chart) {
         return _chart;
     };
 
+    /**
+     * Since dc.js 2.0, there has been {@link https://github.com/dc-js/dc.js/issues/949 an issue}
+     * where points are filtered to the current domain. While this is a useful optimization, it is
+     * incorrectly implemented: the next point outside the domain is required in order to draw lines
+     * that are clipped to the bounds, as well as bars that are partly clipped.
+     *
+     * A fix will be included in dc.js 2.1.x, but a workaround is needed for dc.js 2.0 and until
+     * that fix is published, so set this flag to skip any filtering of points.
+     *
+     * Once the bug is fixed, this flag will have no effect, and it will be deprecated.
+     * @method evadeDomainFilter
+     * @memberof dc.stackMixin
+     * @instance
+     * @param {Boolean} [evadeDomainFilter=false]
+     * @returns {Boolean|dc.stackMixin}
+     */
+    _chart.evadeDomainFilter = function (evadeDomainFilter) {
+        if (!arguments.length) {
+            return _evadeDomainFilter;
+        }
+        _evadeDomainFilter = evadeDomainFilter;
+        return _chart;
+    };
+
     function visability (l) {
         return !l.hidden;
     }

web/examples/range-series.html

@@ -35,12 +35,11 @@
   focusChart
     .width(768)
     .height(480)
-    .chart(function(c) { return dc.lineChart(c).interpolate('basis'); })
+    .chart(function(c) { return dc.lineChart(c).interpolate('basis').evadeDomainFilter(true); })
     .x(d3.scale.linear().domain([0,20]))
     .brushOn(false)
     .yAxisLabel("Measured Speed km/s")
     .xAxisLabel("Run")
-    .clipPadding(10)
     .elasticY(true)
     .dimension(runDimension)
     .group(runGroup)