Skip to content

Commit a3936b7

Browse files
committed
prepping for review
1 parent bf254ce commit a3936b7

File tree

4 files changed

+19
-9
lines changed

4 files changed

+19
-9
lines changed

NEWS.md

+14-8
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,36 @@
11
# gtsummary (development version)
22

3-
* Bug fix in `add_overall.tbl_custom_summary()` due to extraneous arguments being passed to primary function. (#2027)
3+
### New Features and Functions
44

55
* Added function `tbl_hierarchical()`, `tbl_hierarchical_count()`, `tbl_ard_hierarchical()`, `brdg_hierarchical()`, and `pier_summary_hierarchical()`. Consider these functions as a preview. We will be making changes without the full deprecation cycle in the coming releases. (#1872)
66

77
* Adding the `style_*(prefix, suffix)` and `label_style_*(prefix, suffix)` for adding a string before or after the formatted results. These arguments have not been added to the p-value formatting functions. (#1690)
88

9-
* Bug fix in `add_p.tbl_survfit()` when the original call included `tbl_survfit(type)` specification. (#2002)
9+
* Added argument `tbl_ard_summary(overall)`. When `TRUE`, the ARD is parsed into primary ARD and the Overall ARD and we run `tbl_ard_summary() |> add_overall()`. (#1940)
10+
11+
* Added `add_stat_label.tbl_ard_summary()` method. (#1969)
12+
13+
### Other Updates
14+
15+
* Headers in {gt} tables being exported to PDF do not support the `\n` line breaker. Previously, line breakers were stripped from the header in the `print.gtsummary()` S3 method. But this did not apply to users utilizing `as_gt()` to further customize their tables. As a result, the line breaking strip has been migrated to `as_gt()`. (#1960)
1016

1117
* Migrated the `tbl_survfit.list(conf.level)` up to `tbl_survfit.data.frame(conf.level)` where the confidence level is passed to `survival::survfit()`.
1218

1319
* Update in `tbl_ard_summary()` to better handle non-standard ARDs (i.e. not our typical continuous or categorical summaries) by assigning them a default summary type. (#1991)
1420

1521
* Made the `oneway.test()` available in `add_p.tbl_continuous()`. (#1970)
1622

17-
* Added argument `tbl_ard_summary(overall)`. When `TRUE`, the ARD is parsed into primary ARD and the Overall ARD and we run `tbl_ard_summary() |> add_overall()`. (#1940)
23+
* Removed the deprecated `'aov'` test from the `tests.R` file listing available tests. (#1970)
1824

19-
* Added `add_stat_label.tbl_ard_summary()` method. (#1969)
25+
* Removed documentation for the `add_overall.tbl_ard_summary(digits)` argument, which was never meant to be a part of this function. (#1975)
2026

21-
* Headers in {gt} tables being exported to PDF do not support the `\n` line breaker. Previously, line breakers were stripped from the header in the `print.gtsummary()` S3 method. But this did not apply to users utilizing `as_gt()` to further customize their tables. As a result, the line breaking strip has been migrated to `as_gt()`. (#1960)
27+
### Bug Fixes
2228

23-
* Removed the `"tbl_summary-arg:statistic"` theme that was incorrectly added to `tbl_continuous()`.
29+
* Bug fix in `add_overall.tbl_custom_summary()` due to extraneous argument being passed to `tbl_custom_summary()`. (#2027)
2430

25-
* Removed the deprecated `'aov'` test from the `tests.R` file listing available tests. (#1970)
31+
* Bug fix in `add_p.tbl_survfit()` when the original call included `tbl_survfit(type)` specification. (#2002)
2632

27-
* Removed documentation for the `add_overall.tbl_ard_summary(digits)` argument, which was never meant to be a part of this function. (#1975)
33+
* Removed the `"tbl_summary-arg:statistic"` theme that was incorrectly added to `tbl_continuous()`.
2834

2935
# gtsummary 2.0.2
3036

R/tbl_ard_hierarchical.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ tbl_ard_hierarchical <- function(cards,
8383
tbl_ard_hierarchical_inputs[["data"]] <- NULL
8484

8585
# fill in missing labels -----------------------------------------------------
86-
default_label <- default_label <- names(data) |> as.list() |> setNames(names(data))
86+
default_label <- default_label <- names(data) |> as.list() |> stats::setNames(names(data))
8787
label <- c(
8888
label, default_label[setdiff(names(default_label), names(label))]
8989
)[c(variables, if ("overall" %in% names(label)) "overall")]

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11

22
<!-- README.md is generated from README.Rmd. Please edit that file -->
3+
34
<!-- badges: start -->
45

56
[![R-CMD-check](https://github.com/ddsjoberg/gtsummary/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/ddsjoberg/gtsummary/actions/workflows/R-CMD-check.yaml)

inst/WORDLIST

+3
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ cli
4646
codebase
4747
coef
4848
conf
49+
coxph
4950
customizability
5051
customizable
5152
der
@@ -61,6 +62,7 @@ forcats
6162
ftExtra
6263
ggplot
6364
ggstats
65+
glm
6466
hochberg
6567
holm
6668
hommel
@@ -72,6 +74,7 @@ labelled
7274
lifecycle
7375
likert
7476
linebreaks
77+
lm
7578
lme
7679
mL
7780
mis

0 commit comments

Comments
 (0)