Autocomplete renderer should affect cell not inner div

developher-net · developher-net · commit 99d8a35fbc6e · 2013-10-01T11:56:47.000-07:00
diff --git a/dist/jquery.handsontable.css b/dist/jquery.handsontable.css
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)
+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)
  */
 
 .handsontable {
diff --git a/dist/jquery.handsontable.full.css b/dist/jquery.handsontable.full.css
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)
+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)
  */
 
 .handsontable {
diff --git a/dist/jquery.handsontable.full.js b/dist/jquery.handsontable.full.js
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)
+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)
  */
 /*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */
 
@@ -3633,7 +3633,9 @@ Handsontable.AutocompleteRenderer = function (instance, TD, row, col, prop, valu
     instance.rootElement.on('mouseup', '.htAutocompleteArrow', instance.acArrowListener); //this way we don't bind event listener to each arrow. We rely on propagation instead
   }
 
-  Handsontable.TextRenderer(instance, TEXT, row, col, prop, value, cellProperties);
+  Handsontable.TextRenderer(instance, TD, row, col, prop, value, cellProperties);
+  var escaped = Handsontable.helper.stringify(value);
+  instance.view.wt.wtDom.fastInnerText(TEXT, escaped);
 
   if (!TEXT.firstChild) { //http://jsperf.com/empty-node-if-needed
     //otherwise empty fields appear borderless in demo/renderers.html (IE)
diff --git a/dist/jquery.handsontable.js b/dist/jquery.handsontable.js
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)
+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)
  */
 /*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */
 
@@ -3633,7 +3633,9 @@ Handsontable.AutocompleteRenderer = function (instance, TD, row, col, prop, valu
     instance.rootElement.on('mouseup', '.htAutocompleteArrow', instance.acArrowListener); //this way we don't bind event listener to each arrow. We rely on propagation instead
   }
 
-  Handsontable.TextRenderer(instance, TEXT, row, col, prop, value, cellProperties);
+  Handsontable.TextRenderer(instance, TD, row, col, prop, value, cellProperties);
+  var escaped = Handsontable.helper.stringify(value);
+  instance.view.wt.wtDom.fastInnerText(TEXT, escaped);
 
   if (!TEXT.firstChild) { //http://jsperf.com/empty-node-if-needed
     //otherwise empty fields appear borderless in demo/renderers.html (IE)
diff --git a/dist_wc/x-handsontable/jquery.handsontable.full.css b/dist_wc/x-handsontable/jquery.handsontable.full.css
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)
+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)
  */
 
 .handsontable {
diff --git a/dist_wc/x-handsontable/jquery.handsontable.full.js b/dist_wc/x-handsontable/jquery.handsontable.full.js
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)
+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)
  */
 /*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */
 
@@ -3633,7 +3633,9 @@ Handsontable.AutocompleteRenderer = function (instance, TD, row, col, prop, valu
     instance.rootElement.on('mouseup', '.htAutocompleteArrow', instance.acArrowListener); //this way we don't bind event listener to each arrow. We rely on propagation instead
   }
 
-  Handsontable.TextRenderer(instance, TEXT, row, col, prop, value, cellProperties);
+  Handsontable.TextRenderer(instance, TD, row, col, prop, value, cellProperties);
+  var escaped = Handsontable.helper.stringify(value);
+  instance.view.wt.wtDom.fastInnerText(TEXT, escaped);
 
   if (!TEXT.firstChild) { //http://jsperf.com/empty-node-if-needed
     //otherwise empty fields appear borderless in demo/renderers.html (IE)
diff --git a/src/renderers/autocompleteRenderer.js b/src/renderers/autocompleteRenderer.js
@@ -28,7 +28,9 @@ Handsontable.AutocompleteRenderer = function (instance, TD, row, col, prop, valu
     instance.rootElement.on('mouseup', '.htAutocompleteArrow', instance.acArrowListener); //this way we don't bind event listener to each arrow. We rely on propagation instead
   }
 
-  Handsontable.TextRenderer(instance, TEXT, row, col, prop, value, cellProperties);
+  Handsontable.TextRenderer(instance, TD, row, col, prop, value, cellProperties);
+  var escaped = Handsontable.helper.stringify(value);
+  instance.view.wt.wtDom.fastInnerText(TEXT, escaped);
 
   if (!TEXT.firstChild) { //http://jsperf.com/empty-node-if-needed
     //otherwise empty fields appear borderless in demo/renderers.html (IE)

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Licensed under the MIT license.`
`7`	`7`	`* http://handsontable.com/`
`8`	`8`	`*`
`9`		`- * Date: Tue Oct 01 2013 13:17:18 GMT+0200 (Central European Daylight Time)`
	`9`	`+ * Date: Tue Oct 01 2013 11:54:46 GMT-0700 (PDT)`
`10`	`10`	`*/`
`11`	`11`
`12`	`12`	`.handsontable {`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,9 @@ Handsontable.AutocompleteRenderer = function (instance, TD, row, col, prop, valu`
`28`	`28`	`instance.rootElement.on('mouseup', '.htAutocompleteArrow', instance.acArrowListener); //this way we don't bind event listener to each arrow. We rely on propagation instead`
`29`	`29`	`}`
`30`	`30`
`31`		`- Handsontable.TextRenderer(instance, TEXT, row, col, prop, value, cellProperties);`
	`31`	`+ Handsontable.TextRenderer(instance, TD, row, col, prop, value, cellProperties);`
	`32`	`+ var escaped = Handsontable.helper.stringify(value);`
	`33`	`+ instance.view.wt.wtDom.fastInnerText(TEXT, escaped);`
`32`	`34`
`33`	`35`	`if (!TEXT.firstChild) { //http://jsperf.com/empty-node-if-needed`
`34`	`36`	`//otherwise empty fields appear borderless in demo/renderers.html (IE)`