Skip to content
This repository was archived by the owner on Jul 25, 2019. It is now read-only.

Commit 9c2915d

Browse files
committed
Changed all boolean casts that were using Boolean() function to use double negation (!!), which is faster: http://stackoverflow.com/questions/15335452/why-is-boolean-so-slow-in-javascript
1 parent 2930029 commit 9c2915d

6 files changed

+6
-6
lines changed

extensions/jquery.handsontable.removeRow.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
function init() {
1010
var instance = this;
1111

12-
var pluginEnabled = Boolean(instance.getSettings().removeRowPlugin);
12+
var pluginEnabled = !!(instance.getSettings().removeRowPlugin);
1313

1414
if (pluginEnabled) {
1515
bindMouseEvents();

src/plugins/columnSorting.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function HandsontableColumnSorting() {
1212
var sortingSettings = instance.getSettings().columnSorting;
1313
var sortingColumn, sortingOrder;
1414

15-
sortingEnabled = Boolean(sortingSettings);
15+
sortingEnabled = !!(sortingSettings);
1616

1717
if (sortingEnabled) {
1818
instance.sortIndex = [];

src/plugins/contextMenu.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(function(Handsontable){
22
function init(){
33
var instance = this;
4-
var pluginEnabled = Boolean(instance.getSettings().contextMenu);
4+
var pluginEnabled = !!(instance.getSettings().contextMenu);
55

66
if(pluginEnabled){
77
createContextMenu.call(instance);

src/plugins/manualColumnMove.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ function HandsontableManualColumnMove() {
103103
this.init = function (source) {
104104
var instance = this;
105105

106-
var manualColMoveEnabled = Boolean(this.getSettings().manualColumnMove);
106+
var manualColMoveEnabled = !!(this.getSettings().manualColumnMove);
107107

108108
if (manualColMoveEnabled) {
109109
var initialManualColumnPositions = this.getSettings().manualColumnMove;

src/plugins/manualColumnResize.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ function HandsontableManualColumnResize() {
132132

133133
this.init = function (source) {
134134
var instance = this;
135-
var manualColumnWidthEnabled = Boolean(this.getSettings().manualColumnResize);
135+
var manualColumnWidthEnabled = !!(this.getSettings().manualColumnResize);
136136

137137
if (manualColumnWidthEnabled) {
138138
var initialColumnWidths = this.getSettings().manualColumnResize;

src/plugins/persistentState.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function Storage(prefix) {
6969
var instance = this,
7070
pluginSettings = instance.getSettings()['persistentState'];
7171

72-
plugin.enabled = Boolean(pluginSettings);
72+
plugin.enabled = !!(pluginSettings);
7373

7474
if (!plugin.enabled) {
7575
removeHooks.call(instance);

0 commit comments

Comments
 (0)