bugfix: fix scrolling on border cases when table height was the size of the container

Author: warpech

Diff for: CHANGELOG.md

@@ -5,6 +5,7 @@ Bugfixes:
 - mouse wheel didn't scroll the window when cursor was over Handsontable ([#383](https://github.com/warpech/jquery-handsontable/issues/383), [#627](https://github.com/warpech/jquery-handsontable/issues/627))
 - methods `countVisibleRows` and `countVisibleCols` were broken since version 0.9.0
 - WalkontableDom.prototype.offset now returns offset relatively to the document also for position: fixed
+- fix scrolling on border cases when table height was the size of the container
 
 Docs:
 - new demo page [Options](http://handsontable.com/demo/options.html). Currently features one option but this will improve over time

Diff for: src/3rdparty/walkontable/src/table.js

@@ -530,9 +530,9 @@ WalkontableTable.prototype.isColumnInViewport = function (c) {
 };
 
 WalkontableTable.prototype.isLastRowFullyVisible = function () {
-  return (this.getLastVisibleRow() === this.instance.getSetting('totalRows') - 1 && this.rowStrategy.remainingSize <= 0);
+  return (this.getLastVisibleRow() === this.instance.getSetting('totalRows') - 1 && !this.rowStrategy.isLastIncomplete());
 };
 
 WalkontableTable.prototype.isLastColumnFullyVisible = function () {
-  return (this.getLastVisibleColumn() === this.instance.getSetting('totalColumns') - 1 && this.columnStrategy.remainingSize <= 0);
+  return (this.getLastVisibleColumn() === this.instance.getSetting('totalColumns') - 1 && !this.columnStrategy.isLastIncomplete());
 };

Diff for: src/3rdparty/walkontable/src/viewport.js

@@ -34,7 +34,7 @@ WalkontableViewport.prototype.getWorkspaceHeight = function (proposedHeight) {
   }
 
   if (height !== Infinity) {
-    if (proposedHeight > height) {
+    if (proposedHeight >= height) {
       height -= this.instance.getSetting('scrollbarHeight');
     }
     else if (this.instance.wtScrollbars.horizontal.visible) {
@@ -58,7 +58,7 @@ WalkontableViewport.prototype.getWorkspaceWidth = function (proposedWidth) {
   }
 
   if (width !== Infinity) {
-    if (proposedWidth > width) {
+    if (proposedWidth >= width) {
       width -= this.instance.getSetting('scrollbarWidth');
     }
     else if (this.instance.wtScrollbars.vertical.visible) {

Diff for: src/3rdparty/walkontable/test/jasmine/spec/table.spec.js

@@ -783,7 +783,7 @@ describe('WalkontableTable', function () {
   });
 
   describe('isLastRowFullyVisible', function () {
-    /*it('should be false because it is only partially visible', function () {
+    it('should be false because it is only partially visible', function () {
       createDataArray(8, 4);
 
       var wt = new Walkontable({
@@ -800,7 +800,7 @@ describe('WalkontableTable', function () {
       wt.draw();
 
       expect(wt.wtTable.isLastRowFullyVisible()).toEqual(false);
-    });*/
+    });
 
     it('should be true because it is fully visible', function () {
       createDataArray(8, 4);