Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Parser Packages and Rename devfile/parser #193

Closed
adisky opened this issue Oct 23, 2020 · 1 comment
Closed

Restructure Parser Packages and Rename devfile/parser #193

adisky opened this issue Oct 23, 2020 · 1 comment
Labels
lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@adisky
Copy link

adisky commented Oct 23, 2020

Is your task related to a problem? Please describe.

As the current code is imported from odo, It is following the same structure here

if we want to consume the parser functions, we need to do import github.com/devfile/parser/pkg/devfile/parser which looks redundant.

Describe the solution you'd like

  • Rename devfile/parser to devfile/library
    devfile/parser ----> `devfile/library

  • Reconsider the structure, a rough idea

devfile/library
- pkg/                   // all we want to expose as library
     - parser/
     - validate/
     - generator/
     - utils/
- tests/
- utils/                // internal utils
- vendor/
Copy link

github-actions bot commented Jul 9, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 9, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Sep 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2024
@github-project-automation github-project-automation bot moved this to Done ✅ in Devfile Project Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

1 participant