Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile parser should not return internal context from parse function #194

Closed
adisky opened this issue Oct 23, 2020 · 1 comment
Closed
Labels
lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@adisky
Copy link

adisky commented Oct 23, 2020

Is your feature request related to a problem? Please describe.
Currently Parse function in devfile parser returns DevfileObj which contains DevfileCtx, DevfileCtx is internal structure and not of any use for library consumer.

Describe the solution you'd like
Return Devfile Structure directly or if returning the interface, we can use simple wrapper instead of DevfileObj

type DevfileWrapper Struct {
 APIVersion String
 Data data.DevfileData
}

Describe alternatives you've considered
None I have thought of :)

Additional context
Not required

Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Jul 10, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Sep 8, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
@github-project-automation github-project-automation bot moved this to Done ✅ in Devfile Project Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

1 participant