Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devfile/parser should use the devfile/api util override and merge functions #198

Closed
maysunfaisal opened this issue Oct 28, 2020 · 0 comments
Assignees
Labels
area/library Common devfile library for interacting with devfiles

Comments

@maysunfaisal
Copy link
Member

Currently, devfile/parser has override functions for each devfile object ie; components, commands etc which was the implementation that was imported over from the Odo repository. Here is the implementation in devfile/parser - https://github.com/devfile/parser/blob/master/pkg/devfile/parser/devfileobj.go#L33

However, devfile/api has override and merge util funcs defined in pkg https://github.com/devfile/api/tree/master/pkg/utils/overriding

I tested out the devfile/api funcs by integrating it into devfile/parser & odo code base and it seems to work fine. We should switch to it since it is more fleshed out and takes care of all the devfile objects.

@maysunfaisal maysunfaisal added the area/library Common devfile library for interacting with devfiles label Oct 28, 2020
@yangcao77 yangcao77 self-assigned this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Development

No branches or pull requests

2 participants