You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
It seems that vscodeLaunch and vscodeTask are not generic enough and then I'm not sure it belongs to devfile API spec.
Describe the solution you'd like
Get rid of it but allow to use them with annotations or with a more generic approach like 'name of file to add or key' and the content of the inlined content
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered:
benoitf
changed the title
remove vscodeLaunch / vscodeTask
Make vscodeLaunch / vscodeTask more generic
Feb 15, 2021
in all of the devfiles we have in Che, we only use vscode-launch to define the debug mode. In all the other use case, we are using commands-actions from devfile v1. This format has been there for since Che6 so used in the old GWT IDE and now consumed by Che-Theia. So I suggest we should consider having something similar when it is to define the debug configuration.
You mean a mechanism like I described in eclipse-che/che#15518 (comment) ? Writing files to disk is fine, but we should take care to use intermediate formats that can be interpreted by glue code, not directly bake the structure of the workspace. Otherwise, we'll run into problems like eclipse-che/che#17975 in the future again.
Wouldn't simply allowing free-form attributes on the proper devfile objects allow to attach any kind of IDE-specific configuration to those objects? We would simply have to establish a scheme to avoid key collisions.
We'll remove the vscodeLaunch and vscodeTask from the devfile 2.0.x spec. Tools can use annotation with the attributes field under the projects/metadata section to specify IDE-specific info. This change needs to be done on both 2.0.x and 2.1.
Is your feature request related to a problem? Please describe.
It seems that vscodeLaunch and vscodeTask are not generic enough and then I'm not sure it belongs to devfile API spec.
Describe the solution you'd like
Get rid of it but allow to use them with annotations or with a more generic approach like 'name of file to add or key' and the content of the inlined content
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: