Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vscodeLaunch / vscodeTask more generic #344

Closed
benoitf opened this issue Feb 12, 2021 · 4 comments
Closed

Make vscodeLaunch / vscodeTask more generic #344

benoitf opened this issue Feb 12, 2021 · 4 comments
Assignees
Labels
area/api Enhancement or issue related to the api/devfile specification
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 12, 2021

Is your feature request related to a problem? Please describe.
It seems that vscodeLaunch and vscodeTask are not generic enough and then I'm not sure it belongs to devfile API spec.

Describe the solution you'd like
Get rid of it but allow to use them with annotations or with a more generic approach like 'name of file to add or key' and the content of the inlined content

Describe alternatives you've considered
N/A

Additional context
N/A

@benoitf benoitf changed the title remove vscodeLaunch / vscodeTask Make vscodeLaunch / vscodeTask more generic Feb 15, 2021
@sunix
Copy link
Contributor

sunix commented Feb 16, 2021

in all of the devfiles we have in Che, we only use vscode-launch to define the debug mode. In all the other use case, we are using commands-actions from devfile v1. This format has been there for since Che6 so used in the old GWT IDE and now consumed by Che-Theia. So I suggest we should consider having something similar when it is to define the debug configuration.

@tsmaeder
Copy link

You mean a mechanism like I described in eclipse-che/che#15518 (comment) ? Writing files to disk is fine, but we should take care to use intermediate formats that can be interpreted by glue code, not directly bake the structure of the workspace. Otherwise, we'll run into problems like eclipse-che/che#17975 in the future again.

@tsmaeder
Copy link

Wouldn't simply allowing free-form attributes on the proper devfile objects allow to attach any kind of IDE-specific configuration to those objects? We would simply have to establish a scheme to avoid key collisions.

@elsony
Copy link
Contributor

elsony commented Feb 16, 2021

We'll remove the vscodeLaunch and vscodeTask from the devfile 2.0.x spec. Tools can use annotation with the attributes field under the projects/metadata section to specify IDE-specific info. This change needs to be done on both 2.0.x and 2.1.

@yangcao77 yangcao77 added the area/api Enhancement or issue related to the api/devfile specification label Feb 16, 2021
@elsony elsony added this to the 2.1 milestone Feb 16, 2021
@yangcao77 yangcao77 self-assigned this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification
Projects
None yet
Development

No branches or pull requests

5 participants