Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devfile/library Get func for filtering #373

Closed
maysunfaisal opened this issue Mar 16, 2021 · 0 comments · Fixed by devfile/library#71
Closed

Update devfile/library Get func for filtering #373

maysunfaisal opened this issue Mar 16, 2021 · 0 comments · Fixed by devfile/library#71
Assignees
Labels
area/library Common devfile library for interacting with devfiles

Comments

@maysunfaisal
Copy link
Member

devfile/library provides GetComponents(common.DevfileOptions) ([]v1.Component, error) for reading the components from the devfile. The param DevfileOptions allows consumers to filter components based on the component attribute.

However, devfile/library also has GetDevfileContainerComponents() & GetDevfileVolumeComponents() funcs for getting container and volume components respectively. A cleaner approach would be to consolidate all filtering options via the param DevfileOptions in GetComponents(). Options could be the Component Type(container, kubernetes, volume, etc), Command Type(exec, apply, etc), Command Group Kind(run, debug, etc)

@maysunfaisal maysunfaisal added the area/library Common devfile library for interacting with devfiles label Mar 16, 2021
@maysunfaisal maysunfaisal self-assigned this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant