Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict uri in devfile or URL passed in to library to be a file path #398

Closed
yangcao77 opened this issue Mar 30, 2021 · 0 comments · Fixed by devfile/library#77
Closed
Assignees
Labels
area/library Common devfile library for interacting with devfiles kind/bug Something isn't working

Comments

@yangcao77
Copy link
Contributor

we currently checks if the uri in devfile / URL passed into parser ends with .yaml extension; if not, we make an assumption that the uri is a repo directory contains devfile.yaml or .devfile.yaml, and append the file name at the end before sending a GET request.

However, it does not work for uri: https://registry.devfile.io/devfiles/nodejs, this uri is a valid devfile URL, and should not append any file name at the end.

To resolve this issue, and avoid any confusion. library should restrict uri in devfile or URL passed in to library to be a file path.

@yangcao77 yangcao77 added kind/bug Something isn't working area/library Common devfile library for interacting with devfiles labels Mar 30, 2021
@yangcao77 yangcao77 self-assigned this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant