Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library add apis should process everything before return an error #449

Closed
yangcao77 opened this issue Apr 29, 2021 · 0 comments · Fixed by devfile/library#86
Closed

Library add apis should process everything before return an error #449

yangcao77 opened this issue Apr 29, 2021 · 0 comments · Fixed by devfile/library#86
Assignees
Labels
area/library Common devfile library for interacting with devfiles kind/bug Something isn't working

Comments

@yangcao77
Copy link
Contributor

yangcao77 commented Apr 29, 2021

Add apis tend to return on first error, rather than process everything provided.
For example, pass in 5 components, 4 will be added if the 5th is a duplicate but only 1 will be added if the 2nd is a duplicate.

Expected behavior:
add apis should process everything before return. Any valid elements will be added to the devfileObj, and each invalid element will have an error message. the returned error message should be contain all errors

@yangcao77 yangcao77 added kind/bug Something isn't working area/api Enhancement or issue related to the api/devfile specification labels Apr 29, 2021
@yangcao77 yangcao77 mentioned this issue Apr 29, 2021
8 tasks
@yangcao77 yangcao77 added area/library Common devfile library for interacting with devfiles and removed area/api Enhancement or issue related to the api/devfile specification labels May 4, 2021
@yangcao77 yangcao77 self-assigned this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant