Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Library unit test coverage #489

Closed
29 tasks
kim-tsao opened this issue Jun 9, 2021 · 2 comments
Closed
29 tasks

Improve Library unit test coverage #489

kim-tsao opened this issue Jun 9, 2021 · 2 comments
Assignees
Labels
area/library Common devfile library for interacting with devfiles area/test-automation Test automation for devfile specification and library

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Jun 9, 2021

Is your feature request related to a problem? Please describe.
The numbers are subject to change but as of today, we have the following coverage:

  • generators.go (65.9%)
  • utils.go (91.1%)
  • configurables.go (29.0%)
  • apiVersion.go (89.5%)
  • content.go (85.7%)
  • context.go (28.6%)
  • fakecontext.go (0.0%
  • fs.go (100.0%)
  • schema.go (87.5%)
  • helper.go (93.3%)
  • attributes.go (100.0%)
  • commands.go (97.4%)
  • command_helper.go (80.6%)
  • component_helper.go (100.0%)
  • errors.go (0.0%)
  • options.go (91.7%)
  • project_helper.go (100.0%)
  • components.go (94.2%)
  • events.go (80.0%)
  • header.go (100.0%)
  • parent.go (50.0%)
  • projects.go (97.4%)
  • volumes.go (100.0%)
  • workspace.go (50.0%)
  • versions.go (100.0%)
  • parse.go (74.3%)
  • resolutionContext.go (100.0%)
  • sourceAttribute.go (88.2%)
  • writer.go (75.0%)

Describe the solution you'd like
Our test coverage report shows we have gaps in testing for a number of Library modules. We should try to achieve 100% if possible.

Describe alternatives you've considered

If we don't do this, this is technical debt and will impact the QA of our project

Additional context
Latest test coverage reports can be found in the Actions > Validate PRs workflow

@kim-tsao kim-tsao added area/library Common devfile library for interacting with devfiles area/test-automation Test automation for devfile specification and library labels Jun 9, 2021
@kim-tsao kim-tsao self-assigned this Jun 9, 2021
@kim-tsao
Copy link
Contributor Author

Waiting on mock functions to be available: #383

@kim-tsao
Copy link
Contributor Author

we have codecov now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles area/test-automation Test automation for devfile specification and library
Projects
None yet
Development

No branches or pull requests

1 participant