Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container & service port name should use endpoint name #700

Closed
3 tasks done
yangcao77 opened this issue Dec 7, 2021 · 0 comments · Fixed by devfile/library#128
Closed
3 tasks done

container & service port name should use endpoint name #700

yangcao77 opened this issue Dec 7, 2021 · 0 comments · Fixed by devfile/library#128
Assignees
@yangcao77
Labels
area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles

Comments

@yangcao77
Copy link
Contributor

yangcao77 commented Dec 7, 2021 •
edited
Loading

Which area/kind this issue is related to?

/area api
/area library

Issue Description

To fix redhat-developer/odo#4737 (comment)

  • Change the endpoint name length limitation from 63 chars to 15 chars
  • Change the validation rule to endpoint port. disallow port number duplication.
  • Update devfile library to use the endpoint name as the container&service port name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangcao77 yangcao77

Labels
area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use endpoint name as container port name and service port name yangcao77/library
1 participant
@yangcao77