Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce name filter in DevfileOptions #750

Closed
yangcao77 opened this issue Jan 31, 2022 · 1 comment · Fixed by devfile/library#130
Closed

Introduce name filter in DevfileOptions #750

yangcao77 opened this issue Jan 31, 2022 · 1 comment · Fixed by devfile/library#130
Assignees
Labels
area/library Common devfile library for interacting with devfiles kind/enhancement New feature or request

Comments

@yangcao77
Copy link
Contributor

yangcao77 commented Jan 31, 2022

Which area this feature is related to?

/area library

Which functionality do you think we should add?

Why is this needed? Is your feature request related to a problem?
for #720

Detailed description:
introduce name filter in DevfileOptions, so that consumers can get a particular devfile entry with the entry name.

Describe the solution you'd like

A new field FilterByName will be introduced as the name filter.

common.DevfileOptions{
	FilterByName: string,
}

Just support the simplest case: if name is specified, return the particular entry, and return an empty list if not found (similar as other filters). if no name specified, return the list of entries that qualifies the filter defined.
we do not do any additional support to other specific cases, tools can customize the result as needed.

Describe alternatives you've considered

Additional context

@yangcao77 yangcao77 self-assigned this Jan 31, 2022
@yangcao77 yangcao77 added area/library Common devfile library for interacting with devfiles kind/enhancement New feature or request labels Jan 31, 2022
@yangcao77
Copy link
Contributor Author

Blocks #720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant