Updated get func test check

Signed-off-by: Maysun J Faisal <[email protected]>

Author: maysunfaisal

pkg/devfile/parser/data/v2/commands_test.go

@@ -185,20 +185,12 @@ func TestDevfile200_GetCommands(t *testing.T) {
 				t.Errorf("TestDevfile200_GetCommands() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			} else if err == nil {
-				assert.Equal(t, len(tt.wantCommands), len(commands), "expected length not the same as returned length")
-
-				for _, devfileCommand := range commands {
-					matched := false
-					for _, wantCommand := range tt.wantCommands {
-						if wantCommand == devfileCommand.Id {
-							matched = true
-						}
-					}
-
-					if !matched {
-						t.Errorf("TestDevfile200_GetCommands() error - command %s not found in the expected list", devfileCommand.Id)
-					}
+				var gotCommands []string
+				for _, command := range commands {
+					gotCommands = append(gotCommands, command.Id)
 				}
+
+				assert.Equal(t, tt.wantCommands, gotCommands, "expected commands not the same as returned commands")
 			}
 		})
 	}

pkg/devfile/parser/data/v2/components_test.go

@@ -310,20 +310,12 @@ func TestGetDevfileComponents(t *testing.T) {
 				t.Errorf("TestGetDevfileComponents() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			} else if err == nil {
-				assert.Equal(t, len(tt.wantComponents), len(components), "expected length not the same as returned length")
-
-				for _, devfileComponent := range components {
-					matched := false
-					for _, wantComponent := range tt.wantComponents {
-						if wantComponent == devfileComponent.Name {
-							matched = true
-						}
-					}
-
-					if !matched {
-						t.Errorf("TestGetDevfileComponents() error - component %s not found in the expected list", devfileComponent.Name)
-					}
+				var gotComponents []string
+				for _, component := range components {
+					gotComponents = append(gotComponents, component.Name)
 				}
+
+				assert.Equal(t, tt.wantComponents, gotComponents, "expected components not the same as returned components")
 			}
 		})
 	}

pkg/devfile/parser/data/v2/projects_test.go

@@ -146,20 +146,12 @@ func TestDevfile200_GetProjects(t *testing.T) {
 				t.Errorf("TestDevfile200_GetProjects() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			} else if err == nil {
-				assert.Equal(t, len(tt.wantProjects), len(projects), "expected length not the same as returned length")
-
-				for _, devfileProject := range projects {
-					matched := false
-					for _, wantProject := range tt.wantProjects {
-						if wantProject == devfileProject.Name {
-							matched = true
-						}
-					}
-
-					if !matched {
-						t.Errorf("TestDevfile200_GetProjects() error - project %s not found in the expected list", devfileProject.Name)
-					}
+				var gotProjects []string
+				for _, project := range projects {
+					gotProjects = append(gotProjects, project.Name)
 				}
+
+				assert.Equal(t, tt.wantProjects, gotProjects, "expected projects not the same as returned projects")
 			}
 		})
 	}
@@ -531,25 +523,17 @@ func TestDevfile200_GetStarterProjects(t *testing.T) {
 				},
 			}
 
-			projects, err := d.GetStarterProjects(tt.filterOptions)
+			starterProjects, err := d.GetStarterProjects(tt.filterOptions)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("TestDevfile200_GetStarterProjects() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			} else if err == nil {
-				assert.Equal(t, len(tt.wantStarterProjects), len(projects), "expected length not the same as returned length")
-
-				for _, devfileProject := range projects {
-					matched := false
-					for _, wantProject := range tt.wantStarterProjects {
-						if wantProject == devfileProject.Name {
-							matched = true
-						}
-					}
-
-					if !matched {
-						t.Errorf("TestDevfile200_GetStarterProjects() error - project %s not found in the expected list", devfileProject.Name)
-					}
+				var gotStarterProjects []string
+				for _, starterProject := range starterProjects {
+					gotStarterProjects = append(gotStarterProjects, starterProject.Name)
 				}
+
+				assert.Equal(t, tt.wantStarterProjects, gotStarterProjects, "expected starter projects not the same as returned starter projects")
 			}
 		})
 	}