Skip to content

Commit 964bbca

Browse files
committed
check for expect value in unit tests
Signed-off-by: Stephanie <[email protected]>
1 parent a35b85d commit 964bbca

File tree

3 files changed

+30
-0
lines changed

3 files changed

+30
-0
lines changed

pkg/devfile/parser/data/v2/commands_test.go

+7
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package v2
22

33
import (
44
"fmt"
5+
"github.com/kylelemons/godebug/pretty"
56
"reflect"
67
"testing"
78

@@ -318,7 +319,13 @@ func TestDevfile200_AddCommands(t *testing.T) {
318319
t.Errorf("TestDevfile200_AddCommands() error = %v, wantErr %v", err, tt.wantErr)
319320
} else if tt.wantErr != nil {
320321
assert.Regexp(t, *tt.wantErr, err.Error(), "Error message should match")
322+
} else {
323+
wantCommands := append(tt.currentCommands, tt.newCommands...)
324+
if !reflect.DeepEqual(d.Commands, wantCommands) {
325+
t.Errorf("TestDevfile200_AddCommands() wanted: %v, got: %v, difference at %v", wantCommands, d.Commands, pretty.Compare(wantCommands, d.Commands))
326+
}
321327
}
328+
322329
})
323330
}
324331
}

pkg/devfile/parser/data/v2/components_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package v2
22

33
import (
44
"fmt"
5+
"github.com/kylelemons/godebug/pretty"
56
"reflect"
67
"testing"
78

@@ -104,6 +105,11 @@ func TestDevfile200_AddComponent(t *testing.T) {
104105
t.Errorf("TestDevfile200_AddComponents() error = %v, wantErr %v", err, tt.wantErr)
105106
} else if tt.wantErr != nil {
106107
assert.Regexp(t, *tt.wantErr, err.Error(), "Error message should match")
108+
} else {
109+
wantComponents := append(tt.currentComponents, tt.newComponents...)
110+
if !reflect.DeepEqual(d.Components, wantComponents) {
111+
t.Errorf("TestDevfile200_AddComponents() wanted: %v, got: %v, difference at %v", wantComponents, d.Components, pretty.Compare(wantComponents, d.Components))
112+
}
107113
}
108114
})
109115
}

pkg/devfile/parser/data/v2/events_test.go

+17
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package v2
22

33
import (
44
"fmt"
5+
"github.com/kylelemons/godebug/pretty"
56
"github.com/stretchr/testify/assert"
67
"reflect"
78
"testing"
@@ -16,6 +17,7 @@ func TestDevfile200_AddEvents(t *testing.T) {
1617
name string
1718
currentEvents *v1.Events
1819
newEvents v1.Events
20+
wantEvents v1.Events
1921
wantErr *string
2022
}{
2123
{
@@ -30,6 +32,12 @@ func TestDevfile200_AddEvents(t *testing.T) {
3032
PostStart: []string{"postStart1"},
3133
},
3234
},
35+
wantEvents: v1.Events{
36+
DevWorkspaceEvents: v1.DevWorkspaceEvents{
37+
PreStart: []string{"preStart1"},
38+
PostStart: []string{"postStart1"},
39+
},
40+
},
3341
wantErr: nil,
3442
},
3543
{
@@ -40,6 +48,11 @@ func TestDevfile200_AddEvents(t *testing.T) {
4048
PostStart: []string{"postStart1"},
4149
},
4250
},
51+
wantEvents: v1.Events{
52+
DevWorkspaceEvents: v1.DevWorkspaceEvents{
53+
PostStart: []string{"postStart1"},
54+
},
55+
},
4356
wantErr: nil,
4457
},
4558
{
@@ -78,6 +91,10 @@ func TestDevfile200_AddEvents(t *testing.T) {
7891
t.Errorf("TestDevfile200_AddEvents() error = %v, wantErr %v", err, tt.wantErr)
7992
} else if tt.wantErr != nil {
8093
assert.Regexp(t, *tt.wantErr, err.Error(), "Error message should match")
94+
} else {
95+
if !reflect.DeepEqual(*d.Events, tt.wantEvents) {
96+
t.Errorf("TestDevfile200_AddComponents() wanted: %v, got: %v, difference at %v", tt.wantEvents, *d.Events, pretty.Compare(tt.wantEvents, *d.Events))
97+
}
8198
}
8299

83100
})

0 commit comments

Comments
 (0)