Use instance doubles and proper stubbed objects

Author: tagliala

.rubocop_todo.yml

@@ -5,11 +5,11 @@
 RSpec.describe OmniAuth::Strategies::CAS::LogoutRequest do
   subject(:call) { described_class.new(strategy, request).call(options) }
 
-  let(:strategy) { double('strategy') }
+  let(:strategy) { instance_double(OmniAuth::Strategies::CAS) }
   let(:env) do
     { 'rack.input' => StringIO.new('', 'r') }
   end
-  let(:request) { double('request', params: params, env: env) }
+  let(:request) { instance_double(Rack::Request, params: params, env: env) }
   let(:params) { { 'url' => url, 'logoutRequest' => logout_request_xml } }
   let(:url) { 'http://example.org/signed_in' }
   let(:logout_request_xml) do

spec/omniauth/strategies/cas/logout_request_spec.rb

@@ -4,14 +4,14 @@
 
 RSpec.describe OmniAuth::Strategies::CAS::ServiceTicketValidator do
   let(:strategy) do
-    double('strategy',
-           service_validate_url: 'https://example.org/serviceValidate')
+    instance_double(OmniAuth::Strategies::CAS, service_validate_url: 'https://example.org/serviceValidate')
   end
   let(:provider_options) do
-    double('provider_options',
-           disable_ssl_verification?: false,
-           merge_multivalued_attributes: false,
-           ca_path: '/etc/ssl/certsZOMG')
+    OmniAuth::Strategy::Options.new(
+      disable_ssl_verification: false,
+      merge_multivalued_attributes: false,
+      ca_path: '/etc/ssl/certsZOMG'
+    )
   end
   let(:validator) do
     described_class.new(strategy, provider_options, '/foo', nil)
@@ -30,7 +30,10 @@
     end
 
     it 'uses the configured CA path' do
+      allow(provider_options).to receive(:ca_path)
+
       call
+
       expect(provider_options).to have_received :ca_path
     end
   end
@@ -58,10 +61,9 @@
 
     context 'when merging multivalued attributes' do
       let(:provider_options) do
-        double('provider_options',
-               disable_ssl_verification?: false,
-               merge_multivalued_attributes: true,
-               ca_path: '/etc/ssl/certsZOMG')
+        OmniAuth::Strategy::Options.new(
+          merge_multivalued_attributes: true
+        )
       end
 
       it 'parses multivalued user info from the response' do

spec/omniauth/strategies/cas/service_ticket_validator_spec.rb

@@ -268,12 +268,12 @@
         XML
       end
 
-      let(:logout_request) { double('logout_request', call: [200, {}, 'OK']) }
+      let(:logout_request) { instance_double(MyCasProvider::LogoutRequest, call: [200, {}, 'OK']) }
 
       before do
-        allow_any_instance_of(MyCasProvider)
-          .to receive(:logout_request_service)
-          .and_return double('LogoutRequest', new: logout_request)
+        allow(MyCasProvider::LogoutRequest)
+          .to receive(:new)
+          .and_return logout_request
 
         sso_logout_request
       end