Stdavis recursive undef (#107)

* Add an optional `recursive` parameter to `require.undef`

Related to dojo/dojo2/issues/16

* Fixing up typing issues, issue-16

* Adding test for undefined modules, issue-16

* ci build

* Updating grunt ts

* More gurnt file changes

Author: rorticus

Gruntfile.js

@@ -61,8 +61,8 @@ module.exports = function (grunt) {
 		'typings:dev',
 		'tslint',
 		'clean:dev',
-		'ts:dev',
-		'ts:tests',
+		'dojo-ts:dev',
+		'dojo-ts:tests',
 		'copy:staticTestFiles'
 	]);
 

src/interfaces.d.ts

@@ -214,7 +214,7 @@ declare namespace DojoLoader {
 		config(config: Config): void;
 		inspect?(name: string): any;
 		nodeRequire?(id: string): any;
-		undef(moduleId: string): void;
+		undef(moduleId: string, recursive?: boolean): void;
 	}
 
 	type SignalType = 'error';

src/loader.ts

@@ -1,5 +1,6 @@
 'use strict';
 import ModuleShim = DojoLoader.ModuleShim;
+import Module = DojoLoader.Module;
 
 declare const load: (module: string) => any;
 declare const Packages: {} | undefined;
@@ -1076,8 +1077,18 @@ declare const Packages: {} | undefined;
 
 	has.add('loader-undef', true);
 	if (has('loader-undef')) {
-		requireModule.undef = function (id: string): void {
-			if (modules[id]) {
+		requireModule.undef = function (id: string, recursive?: boolean): void {
+			const module: Module | undefined = modules[id];
+			const undefDeps = function (mod: Module): void {
+				if (mod.deps) {
+					forEach(mod.deps, undefDeps);
+				}
+				modules[mod.mid] = undefined;
+			};
+			if (module) {
+				if (recursive && module.deps) {
+					forEach(module.deps, undefDeps);
+				}
 				modules[id] = undefined;
 			}
 		};

tests/common/recursive/a.js

@@ -0,0 +1,5 @@
+define([
+	'./b'
+], function (b) {
+	return 'a';
+});

tests/common/recursive/b.js

@@ -0,0 +1,6 @@
+define([
+	'./c',
+	'./d'
+], function (c) {
+	return 'b';
+});

tests/common/recursive/c.js

@@ -0,0 +1 @@
+define([], 'c');

tests/common/recursive/d.js

@@ -0,0 +1,5 @@
+define([
+	'./e'
+], function (e) {
+	return 'd';
+});

tests/common/recursive/e.js

@@ -0,0 +1 @@
+define([], 'e');

tests/unit/require.ts

@@ -631,6 +631,52 @@ registerSuite({
 			dfd.reject('Loading undefined module should throw an error');
 		});
 	},
+	'recurisve undef': {
+		'dependencies are unloaded'(this: any) {
+			let dfd = this.async(DEFAULT_TIMEOUT);
+
+			global.require.config({
+				packages: [
+					{
+						name: 'recursive',
+						location: './_build/tests/common/recursive'
+					}
+				]
+			});
+
+			function checkForUndef(mod: string): boolean {
+				try {
+					global.require(mod);
+				}
+				catch (error) {
+					if (error.message.indexOf(mod) !== -1) {
+						return true;
+					}
+				}
+				return false;
+			}
+
+			global.require([
+				'recursive/a'
+			], function () {
+				global.require.undef('recursive/a', true);
+				const deps: string[] = [ 'recursive/a', 'recursive/b', 'recursive/c', 'recursive/d', 'recursive/e' ];
+				const passed: boolean = deps.every(function (mod: string) {
+					return checkForUndef(mod);
+				});
+				if (passed) {
+					dfd.resolve();
+				}
+				else {
+					dfd.reject('not all dependencies were undefined');
+				}
+			});
+		},
+
+		'modules without dependencies work as expected'() {
+			global.require.undef('invalid-module', true);
+		}
+	},
 
 	plugin: {
 		load(this: any) {